From c00b9c39f36784b86287f8f8d142a7b33200e2a5 Mon Sep 17 00:00:00 2001 From: Byron Jones Date: Fri, 23 Jan 2015 14:25:19 +0800 Subject: Bug 1117345: Can't choose a resolution when trying to resolve a bug (with canconfirm rights) --- extensions/BMO/Extension.pm | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) (limited to 'extensions/BMO') diff --git a/extensions/BMO/Extension.pm b/extensions/BMO/Extension.pm index 458be737f..75ca30d8d 100644 --- a/extensions/BMO/Extension.pm +++ b/extensions/BMO/Extension.pm @@ -512,13 +512,17 @@ sub bug_check_can_change_field { { push (@$priv_results, PRIVILEGES_REQUIRED_NONE); } - elsif ($field eq 'resolution' && + elsif ($field eq 'resolution' && ($new_value eq 'DUPLICATE' || $new_value eq 'WORKSFORME' || - $new_value eq 'INCOMPLETE')) + $new_value eq 'INCOMPLETE' || + ($old_value eq '' && $new_value eq '1'))) { push (@$priv_results, PRIVILEGES_REQUIRED_NONE); } + elsif ($field eq 'dup_id') { + push (@$priv_results, PRIVILEGES_REQUIRED_NONE); + } } elsif ($field eq 'bug_status') { # Disallow reopening of bugs which have been resolved for > 1 year -- cgit v1.2.3-24-g4f1b