From c00e0dc5f96916970fb90b66108c0e92001bf42b Mon Sep 17 00:00:00 2001
From: Dave Lawrence <dlawrence@mozilla.com>
Date: Wed, 13 Feb 2013 15:39:41 -0500
Subject: Bug 836444 - Project Kickoff Form: Legal needs more info in
 Project/Feature Name

---
 extensions/MozProjectReview/Extension.pm               | 18 +++++++++++-------
 .../bug/create/create-moz-project-review.html.tmpl     |  2 ++
 2 files changed, 13 insertions(+), 7 deletions(-)

(limited to 'extensions/MozProjectReview')

diff --git a/extensions/MozProjectReview/Extension.pm b/extensions/MozProjectReview/Extension.pm
index bb52c0c5a..b02120ee4 100644
--- a/extensions/MozProjectReview/Extension.pm
+++ b/extensions/MozProjectReview/Extension.pm
@@ -92,7 +92,7 @@ sub post_bug_after_creation {
 
     if ($do_sec_review) {
         my $bug_data = {
-            short_desc   => 'Security Review for ' . $bug->short_desc,
+            short_desc   => 'Security Review: ' . $bug->short_desc,
             product      => 'mozilla.org',
             component    => 'Security Assurance: Review Request',
             bug_severity => 'normal',
@@ -126,8 +126,12 @@ sub post_bug_after_creation {
                          : $params->{relationship_type};
         }
 
+        my $legal_summary = "Legal Review: ";
+        $legal_summary .= $params->{legal_other_party} . " - " if $params->{legal_other_party};
+        $legal_summary .= $bug->short_desc;
+
         my $bug_data = {
-            short_desc   => 'Complete Legal Review for ' . $bug->short_desc,
+            short_desc   => $legal_summary,
             product      => 'Legal',
             component    => $component,
             bug_severity => 'normal',
@@ -146,7 +150,7 @@ sub post_bug_after_creation {
 
     if ($do_finance) {
         my $bug_data = {
-            short_desc   => 'Complete Finance Review for ' . $bug->short_desc,
+            short_desc   => 'Finance Review: ' . $bug->short_desc,
             product      => 'Finance',
             component    => 'Purchase Request Form',
             bug_severity => 'normal',
@@ -164,7 +168,7 @@ sub post_bug_after_creation {
 
     if ($do_data_safety) {
         my $bug_data = {
-            short_desc   => 'Data Safety Review for ' . $bug->short_desc,
+            short_desc   => 'Data Safety Review: ' . $bug->short_desc,
             product      => 'Data Safety',
             component    => 'General',
             bug_severity => 'normal',
@@ -183,7 +187,7 @@ sub post_bug_after_creation {
 
     if ($do_privacy_tech) {
         my $bug_data = {
-            short_desc   => 'Complete Privacy-Technical Review for ' . $bug->short_desc,
+            short_desc   => 'Privacy-Technical Review: ' . $bug->short_desc,
             product      => 'mozilla.org',
             component    => 'Security Assurance: Review Request',
             bug_severity => 'normal',
@@ -202,7 +206,7 @@ sub post_bug_after_creation {
 
     if ($do_privacy_policy) {
         my $bug_data = {
-            short_desc   => 'Complete Privacy-Policy Review for ' . $bug->short_desc,
+            short_desc   => 'Privacy-Policy Review: ' . $bug->short_desc,
             product      => 'Privacy',
             component    => 'Privacy Review',
             bug_severity => 'normal',
@@ -220,7 +224,7 @@ sub post_bug_after_creation {
 
     if ($do_privacy_vendor) {
         my $bug_data = {
-            short_desc   => 'Complete Privacy / Vendor Review for ' . $bug->short_desc,
+            short_desc   => 'Privacy / Vendor Review: ' . $bug->short_desc,
             product      => 'Privacy',
             component    => 'Vendor Review',
             bug_severity => 'normal',
diff --git a/extensions/MozProjectReview/template/en/default/bug/create/create-moz-project-review.html.tmpl b/extensions/MozProjectReview/template/en/default/bug/create/create-moz-project-review.html.tmpl
index 8e62971b0..a1015c168 100644
--- a/extensions/MozProjectReview/template/en/default/bug/create/create-moz-project-review.html.tmpl
+++ b/extensions/MozProjectReview/template/en/default/bug/create/create-moz-project-review.html.tmpl
@@ -45,6 +45,8 @@
     <div id="project_feature_summary_row" class="field_row">
       <span class="field_label required">Project/Feature Name:</span>
       <span class="field_data">
+        <div class="field_description">Be brief yet descriptive as possible. Include name of product, 
+          feature, or name of vendor involved as well if appropriate.</div>
         <input type="text" name="short_desc" id="short_desc" size="60" maxsize="255">
       </span>
     </div>
-- 
cgit v1.2.3-24-g4f1b