From 026a32a69dabcef8cf337326fe70f39bdd7e45b2 Mon Sep 17 00:00:00 2001
From: Byron Jones <bjones@mozilla.com>
Date: Thu, 4 Apr 2013 13:44:35 +0800
Subject: Bug 856110: fix broken review links

---
 extensions/MyDashboard/web/js/flags.js | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

(limited to 'extensions/MyDashboard/web/js/flags.js')

diff --git a/extensions/MyDashboard/web/js/flags.js b/extensions/MyDashboard/web/js/flags.js
index fa06a00d4..29afefabb 100644
--- a/extensions/MyDashboard/web/js/flags.js
+++ b/extensions/MyDashboard/web/js/flags.js
@@ -6,12 +6,6 @@
  * defined by the Mozilla Public License, v. 2.0. 
  */
 
-if (typeof(MyDashboard) == 'undefined') {
-    var MyDashboard = {};
-}
-
-MyDashboard.splinter_base = 'page.cgi?id=splinter.html';
-
 // Flag tables
 YUI({
     base: 'js/yui3/',
@@ -99,11 +93,12 @@ YUI({
     };
 
     var flagNameFormatter = function (o) {
-        if (o.data.attach_id && o.data.is_patch) {
+        if (o.data.attach_id && o.data.is_patch && MyDashboard.splinter_base) {
             return '<a href="' + MyDashboard.splinter_base +
-                   '&bug=' + encodeURIComponent(o.data.bug_id) +
+                   (MyDashboard.splinter_base.indexOf('?') == -1 ? '?' : '&') +
+                   'bug=' + encodeURIComponent(o.data.bug_id) +
                    '&attachment=' + encodeURIComponent(o.data.attach_id) +
-                   '" title="Click flag name to go to patch review page">' +
+                   '" title="Review this patch">' +
                    Y.Escape.html(o.value) + '</a>';
         }
         else {
-- 
cgit v1.2.3-24-g4f1b