From 9adb2c722a30919e530d13d406d4727351255f40 Mon Sep 17 00:00:00 2001 From: Byron Jones Date: Mon, 25 Mar 2013 22:11:54 +0800 Subject: Bug 854386: needinfo doesn't work if user confirmation is required --- extensions/Needinfo/Extension.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'extensions/Needinfo') diff --git a/extensions/Needinfo/Extension.pm b/extensions/Needinfo/Extension.pm index 255e08098..e88e764b2 100644 --- a/extensions/Needinfo/Extension.pm +++ b/extensions/Needinfo/Extension.pm @@ -57,8 +57,7 @@ sub bug_start_of_update { my $cgi = Bugzilla->cgi; my $params = Bugzilla->input_params; - my $needinfo = delete $params->{needinfo}; - if ($user->in_group('canconfirm') && $needinfo) { + if ($user->in_group('canconfirm') && $params->{needinfo}) { # do a match if applicable Bugzilla::User::match_field({ 'needinfo_from' => { 'type' => 'single' } @@ -70,6 +69,7 @@ sub bug_start_of_update { $params->{needinfo_done} = 1; Bugzilla->input_params($params); + my $needinfo = delete $params->{needinfo}; my $needinfo_from = delete $params->{needinfo_from}; my $needinfo_role = delete $params->{needinfo_role}; my $is_private = $params->{'comment_is_private'}; -- cgit v1.2.3-24-g4f1b