From c20a547c86471041956f364cf73980c92f4434cd Mon Sep 17 00:00:00 2001 From: Byron Jones Date: Thu, 22 Nov 2012 01:52:07 +0800 Subject: Bug 813861: needinfo is sending duplicate request emails when the flag is cleared --- extensions/Needinfo/Extension.pm | 19 ------------------- 1 file changed, 19 deletions(-) (limited to 'extensions/Needinfo') diff --git a/extensions/Needinfo/Extension.pm b/extensions/Needinfo/Extension.pm index 7999d6ae7..98644f997 100644 --- a/extensions/Needinfo/Extension.pm +++ b/extensions/Needinfo/Extension.pm @@ -52,8 +52,6 @@ sub bug_start_of_update { my ($self, $args) = @_; my $bug = $args->{bug}; my $old_bug = $args->{old_bug}; - my $timestamp = $args->{timestamp}; - my $changes = $args->{changes}; my $user = Bugzilla->user; my $cgi = Bugzilla->cgi; @@ -151,23 +149,6 @@ sub bug_start_of_update { if (@flags || @new_flags) { $bug->set_flags(\@flags, \@new_flags); - my ($removed, $added) = Bugzilla::Flag->update_flags($bug, $old_bug, $timestamp); - if ($removed || $added) { - my $field = 'flagtypes.name'; - $removed = defined $removed ? $removed : ''; - $added = defined $added ? $added : ''; - - # Do not overwrite other flag changes - if ($changes->{$field}) { - $removed = defined $changes->{$field}->[0] - ? $changes->{$field}->[0] . ", $removed" - : $removed; - $added = defined $changes->{$field}->[1] - ? $changes->{$field}->[1] . ", $added" - : $added; - } - $changes->{$field} = [$removed, $added]; - } } } -- cgit v1.2.3-24-g4f1b