From 7a61871a05c6e4e4df8313c4ba93143101cbb9be Mon Sep 17 00:00:00 2001
From: dklawren <dklawren@users.noreply.github.com>
Date: Mon, 25 Jun 2018 22:35:56 -0400
Subject: Bug 1470966 - "Status" column in Phabricator dashboard isn't very
 useful

---
 extensions/PhabBugz/lib/Util.pm       | 11 +----------
 extensions/PhabBugz/lib/WebService.pm |  1 -
 2 files changed, 1 insertion(+), 11 deletions(-)

(limited to 'extensions/PhabBugz/lib')

diff --git a/extensions/PhabBugz/lib/Util.pm b/extensions/PhabBugz/lib/Util.pm
index c4c9c7992..214bc3fb7 100644
--- a/extensions/PhabBugz/lib/Util.pm
+++ b/extensions/PhabBugz/lib/Util.pm
@@ -274,16 +274,7 @@ sub get_needs_review {
     ThrowCodeError('phabricator_api_error', { reason => 'Malformed Response' })
         unless exists $diffs->{result}{data};
 
-    # extract this reviewer's status from 'attachments'
-    my @result;
-    foreach my $diff (@{ $diffs->{result}{data} }) {
-        my $attachments = delete $diff->{attachments};
-        my $reviewers   = $attachments->{reviewers}{reviewers};
-        my $review      = first { $_->{reviewerPHID} eq $phab_user->phid } @$reviewers;
-        $diff->{fields}{review_status} = $review->{status};
-        push @result, $diff;
-    }
-    return \@result;
+    return $diffs->{result}{data};
 }
 
 1;
diff --git a/extensions/PhabBugz/lib/WebService.pm b/extensions/PhabBugz/lib/WebService.pm
index 5ca811d58..0239ccf74 100644
--- a/extensions/PhabBugz/lib/WebService.pm
+++ b/extensions/PhabBugz/lib/WebService.pm
@@ -116,7 +116,6 @@ sub needs_review {
     foreach my $review (@$reviews) {
         my $review_flat = {
             id     => $review->{id},
-            status => $review->{fields}{review_status},
             title  => $review->{fields}{title},
             url    => Bugzilla->params->{phabricator_base_uri} . 'D' . $review->{id},
         };
-- 
cgit v1.2.3-24-g4f1b