From d87c64e5805adb4bae54b10d517c10463a9251fc Mon Sep 17 00:00:00 2001 From: David Lawrence Date: Wed, 20 Dec 2017 12:17:32 -0500 Subject: Bug 1426424 - feed daemon complains when trying to set an inactive review flag --- extensions/PhabBugz/lib/Feed.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'extensions/PhabBugz') diff --git a/extensions/PhabBugz/lib/Feed.pm b/extensions/PhabBugz/lib/Feed.pm index b2b681bbd..66b05e4ec 100644 --- a/extensions/PhabBugz/lib/Feed.pm +++ b/extensions/PhabBugz/lib/Feed.pm @@ -226,7 +226,7 @@ sub process_revision_change { my (@denied_flags, @new_flags, @removed_flags, %accepted_done, $flag_type); foreach my $flag (@{ $attachment->flags }) { next if $flag->type->name ne 'review'; - $flag_type = $flag->type; + $flag_type = $flag->type if $flag->type->is_active; if (any { $flag->setter->id == $_ } @denied_user_ids) { push(@denied_flags, { id => $flag->id, setter => $flag->setter, status => 'X' }); } @@ -239,7 +239,7 @@ sub process_revision_change { } } - $flag_type ||= first { $_->name eq 'review' } @{ $attachment->flag_types }; + $flag_type ||= first { $_->name eq 'review' && $_->is_active } @{ $attachment->flag_types }; # Create new flags foreach my $user_id (@accepted_user_ids) { -- cgit v1.2.3-24-g4f1b