From ba8c5fd18435d986cc0ac3c44fcc9799b76e8b64 Mon Sep 17 00:00:00 2001
From: Dave Lawrence <dlawrence@mozilla.com>
Date: Thu, 16 Aug 2012 18:40:48 -0400
Subject: More dashboard tweaks/fixes

---
 extensions/ProductDashboard/Extension.pm           |  2 +-
 .../pages/productdashboard/components.html.tmpl    | 15 ++++++++------
 .../pages/productdashboard/duplicates.html.tmpl    |  8 +++-----
 .../pages/productdashboard/popularity.html.tmpl    |  7 +++----
 .../pages/productdashboard/recents.html.tmpl       | 12 ++++++-----
 .../pages/productdashboard/roadmap.html.tmpl       |  7 +++----
 .../pages/productdashboard/summary.html.tmpl       | 23 ++++++++++++++--------
 7 files changed, 41 insertions(+), 33 deletions(-)

(limited to 'extensions/ProductDashboard')

diff --git a/extensions/ProductDashboard/Extension.pm b/extensions/ProductDashboard/Extension.pm
index 3569a13c8..8ccc897ed 100644
--- a/extensions/ProductDashboard/Extension.pm
+++ b/extensions/ProductDashboard/Extension.pm
@@ -111,7 +111,7 @@ sub _page_dashboard {
     if ($current_tab_name eq 'summary') {
         $vars->{'by_priority'} = by_priority($product, $bug_status);
         $vars->{'by_severity'} = by_severity($product, $bug_status);
-        $vars->{'by_assignee'} = by_assignee($product, $bug_status, 25);
+        $vars->{'by_assignee'} = by_assignee($product, $bug_status);
         $vars->{'by_status'}   = by_status($product, $bug_status);
     }
 
diff --git a/extensions/ProductDashboard/template/en/default/pages/productdashboard/components.html.tmpl b/extensions/ProductDashboard/template/en/default/pages/productdashboard/components.html.tmpl
index 0b8bd34c7..7cf60c245 100644
--- a/extensions/ProductDashboard/template/en/default/pages/productdashboard/components.html.tmpl
+++ b/extensions/ProductDashboard/template/en/default/pages/productdashboard/components.html.tmpl
@@ -118,9 +118,6 @@
 
   <script type="text/javascript">
   <!--
-  PD.options = {
-    paginator: new YAHOO.widget.Paginator({ rowsPerPage: 25,  alwaysVisible: false })
-  };
   PD.column_defs = [
     { key:"name", label:"Name", sortable:true },
     { key:"count", label:"Count", sortable:true },
@@ -133,9 +130,15 @@
     { key:"percentage" },
     { key:"bug_list" }
   ];
-  PD.addStatListener("component_counts", "component_counts_table", PD.column_defs, PD.fields, PD.options);
-  PD.addStatListener("version_counts", "version_counts_table", PD.column_defs, PD.fields, PD.options);
-  PD.addStatListener("milestone_counts", "milestone_counts_table", PD.column_defs, PD.fields, PD.options);
+  PD.addStatListener("component_counts", "component_counts_table",
+                     PD.column_defs, PD.fields,
+                     { paginator: new YAHOO.widget.Paginator({ rowsPerPage: 25, alwaysVisible: false }) });
+  PD.addStatListener("version_counts", "version_counts_table",
+                     PD.column_defs, PD.fields,
+                     { paginator: new YAHOO.widget.Paginator({ rowsPerPage: 25, alwaysVisible: false }) });
+  PD.addStatListener("milestone_counts", "milestone_counts_table",
+                     PD.column_defs, PD.fields,
+                     { paginator: new YAHOO.widget.Paginator({ rowsPerPage: 25, alwaysVisible: false }) });
   -->
   </script>
 
diff --git a/extensions/ProductDashboard/template/en/default/pages/productdashboard/duplicates.html.tmpl b/extensions/ProductDashboard/template/en/default/pages/productdashboard/duplicates.html.tmpl
index 07d93da26..bf1cdaeb1 100644
--- a/extensions/ProductDashboard/template/en/default/pages/productdashboard/duplicates.html.tmpl
+++ b/extensions/ProductDashboard/template/en/default/pages/productdashboard/duplicates.html.tmpl
@@ -12,9 +12,6 @@
   
 <script type="text/javascript">
 <!--
-PD.options = {
-  paginator: new YAHOO.widget.Paginator({ rowsPerPage: 25, alwaysVisible: false })
-};
 PD.column_defs = [
   { key:"id", label:"ID", sortable:true, sortOptions:{ sortFunction: PD.sortBugIdLinks } },
   { key:"count", label:"Count", sortable:true },
@@ -33,8 +30,9 @@ PD.fields = [
   { key:"bug_severity" },
   { key:"Summary" }
 ];
-PD.addStatListener("duplicate_counts", "duplicate_counts_table", PD.column_defs, PD.fields, PD.options);
-});
+PD.addStatListener("duplicate_counts", "duplicate_counts_table",
+                   PD.column_defs, PD.fields,
+                   { paginator: new YAHOO.widget.Paginator({ rowsPerPage: 25, alwaysVisible: false }) });
 -->
 </script>
 
diff --git a/extensions/ProductDashboard/template/en/default/pages/productdashboard/popularity.html.tmpl b/extensions/ProductDashboard/template/en/default/pages/productdashboard/popularity.html.tmpl
index ad0f8eca4..5ecad3426 100644
--- a/extensions/ProductDashboard/template/en/default/pages/productdashboard/popularity.html.tmpl
+++ b/extensions/ProductDashboard/template/en/default/pages/productdashboard/popularity.html.tmpl
@@ -12,9 +12,6 @@
   
 <script type="text/javascript">
 <!--
-PD.options = {
-  paginator: new YAHOO.widget.Paginator({ rowsPerPage: 25, alwaysVisible: false })
-};
 PD.column_defs = [
   { key:"id", label:"ID", sortable:true, sortOptions:{ sortFunction: PD.sortBugIdLinks } },
   { key:"count", label:"Count", sortable:true },
@@ -33,7 +30,9 @@ PD.fields = [
   { key:"bug_severity" },
   { key:"Summary" }
 ];
-PD.addStatListener("popularity_counts", "popularity_counts_table", PD.column_defs, PD.fields, PD.options);
+PD.addStatListener("popularity_counts", "popularity_counts_table",
+                   PD.column_defs, PD.fields,
+                   { paginator: new YAHOO.widget.Paginator({ rowsPerPage: 25, alwaysVisible: false }) });
 -->
 </script>
 
diff --git a/extensions/ProductDashboard/template/en/default/pages/productdashboard/recents.html.tmpl b/extensions/ProductDashboard/template/en/default/pages/productdashboard/recents.html.tmpl
index c08e298c8..919a7da97 100644
--- a/extensions/ProductDashboard/template/en/default/pages/productdashboard/recents.html.tmpl
+++ b/extensions/ProductDashboard/template/en/default/pages/productdashboard/recents.html.tmpl
@@ -12,9 +12,6 @@
   
 <script type="text/javascript">
 <!--
-PD.options = {
-  paginator: new YAHOO.widget.Paginator({ rowsPerPage: 25, alwaysVisible: false })
-};
 PD.column_defs = [
   { key:"id", label:"ID", sortable:true, sortOptions:{ sortFunction: PD.sortBugIdLinks } },
   { key:"bug_status", label:"Status", sortable:true },
@@ -31,8 +28,13 @@ PD.fields = [
   { key:"bug_severity" },
   { key:"Summary" }
 ];
-PD.addStatListener("recently_opened", "recently_opened_table", PD.column_defs, PD.fields, PD.options);
-PD.addStatListener("recently_closed", "recently_closed_table", PD.column_defs, PD.fields, PD.options);
+PD.addStatListener("recently_opened", "recently_opened_table",
+                   PD.column_defs, PD.fields,
+                   { paginator: new YAHOO.widget.Paginator({ rowsPerPage: 25, alwaysVisible: false }) });
+
+PD.addStatListener("recently_closed", "recently_closed_table",
+                   PD.column_defs, PD.fields,
+                   { paginator: new YAHOO.widget.Paginator({ rowsPerPage: 25, alwaysVisible: false }) });
 -->
 </script>
 
diff --git a/extensions/ProductDashboard/template/en/default/pages/productdashboard/roadmap.html.tmpl b/extensions/ProductDashboard/template/en/default/pages/productdashboard/roadmap.html.tmpl
index 565a8b996..1597b7a36 100644
--- a/extensions/ProductDashboard/template/en/default/pages/productdashboard/roadmap.html.tmpl
+++ b/extensions/ProductDashboard/template/en/default/pages/productdashboard/roadmap.html.tmpl
@@ -8,9 +8,6 @@
 
 <script type="text/javascript">
 <!--
-PD.options = {
-  paginator: new YAHOO.widget.Paginator({ rowsPerPage: 25, alwaysVisible: false })
-};
 PD.column_defs = [
   { key:"milestone", label:"Milestone", sortable:true },
   { key:"percentage complete", label:"Percentage Complete", sortable:false },
@@ -21,7 +18,9 @@ PD.fields = [
   { key:"percentage complete" },
   { key:"links" }
 ];
-PD.addStatListener("bug_milestones", "bug_milestones_table", PD.column_defs, PD.fields, PD.options);
+PD.addStatListener("bug_milestones", "bug_milestones_table",
+                   PD.column_defs, PD.fields,
+                   { paginator: new YAHOO.widget.Paginator({ rowsPerPage: 25, alwaysVisible: false }) });
 -->
 </script>
 
diff --git a/extensions/ProductDashboard/template/en/default/pages/productdashboard/summary.html.tmpl b/extensions/ProductDashboard/template/en/default/pages/productdashboard/summary.html.tmpl
index a907d3e5b..a7398c823 100644
--- a/extensions/ProductDashboard/template/en/default/pages/productdashboard/summary.html.tmpl
+++ b/extensions/ProductDashboard/template/en/default/pages/productdashboard/summary.html.tmpl
@@ -8,9 +8,6 @@
 
 <script type="text/javascript">
 <!--
-PD.options = {
-  paginator: new YAHOO.widget.Paginator({ rowsPerPage: 25, alwaysVisible: false })
-};
 PD.column_defs = [
   { key:"name", label:"Name", sortable:true },
   { key:"count", label:"Count", sortable:true },
@@ -21,11 +18,21 @@ PD.fields = [
   { key:"count", parser:"number" },
   { key:"percentage" }
 ];
-PD.addStatListener("bug_counts", "bug_counts_table", PD.column_defs, PD.fields, PD.options);
-PD.addStatListener("status_counts", "status_counts_table", PD.column_defs, PD.fields, PD.options);
-PD.addStatListener("priority_counts", "priority_counts_table", PD.column_defs, PD.fields, PD.options);
-PD.addStatListener("severity_counts", "severity_counts_table", PD.column_defs, PD.fields, PD.options);
-PD.addStatListener("assignee_counts", "assignee_counts_table", PD.column_defs, PD.fields, PD.options);
+PD.addStatListener("bug_counts", "bug_counts_table",
+                   PD.column_defs, PD.fields,
+                   { paginator: new YAHOO.widget.Paginator({ rowsPerPage: 25, alwaysVisible: false }) });
+PD.addStatListener("status_counts", "status_counts_table",
+                   PD.column_defs, PD.fields,
+                   { paginator: new YAHOO.widget.Paginator({ rowsPerPage: 25, alwaysVisible: false }) });
+PD.addStatListener("priority_counts", "priority_counts_table",
+                   PD.column_defs, PD.fields,
+                   { paginator: new YAHOO.widget.Paginator({ rowsPerPage: 25, alwaysVisible: false }) });
+PD.addStatListener("severity_counts", "severity_counts_table",
+                   PD.column_defs, PD.fields,
+                   { paginator: new YAHOO.widget.Paginator({ rowsPerPage: 25, alwaysVisible: false }) });
+PD.addStatListener("assignee_counts", "assignee_counts_table",
+                   PD.column_defs, PD.fields,
+                   { paginator: new YAHOO.widget.Paginator({ rowsPerPage: 25, alwaysVisible: false }) });
 -->
 </script>
 
-- 
cgit v1.2.3-24-g4f1b