From b0cd974e5c57ec5781053699fb9b2ffc5697be4c Mon Sep 17 00:00:00 2001 From: Byron Jones Date: Fri, 26 Jul 2013 14:02:34 +0800 Subject: Bug 897473: exclude users from the review suggestions list who have "unavailable" or "PTO" in their real name --- extensions/Review/Extension.pm | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'extensions/Review/Extension.pm') diff --git a/extensions/Review/Extension.pm b/extensions/Review/Extension.pm index d4e9ae761..51755ca2c 100644 --- a/extensions/Review/Extension.pm +++ b/extensions/Review/Extension.pm @@ -18,6 +18,8 @@ use Bugzilla::Error; use Bugzilla::User; use Bugzilla::Util qw(clean_text); +use constant UNAVAILABLE_RE => qr/\b(?:unavailable|pto)\b/i; + # # monkey-patched methods # @@ -58,7 +60,9 @@ sub _reviewers_objs { # so we have to reorder the list my $users = Bugzilla::User->new_from_list($user_ids); my %user_map = map { $_->id => $_ } @$users; - my @reviewers = map { $user_map{$_} } @$user_ids; + my @reviewers = + grep { $_->name !~ UNAVAILABLE_RE } + map { $user_map{$_} } @$user_ids; $object->{reviewers} = \@reviewers; } return $object->{reviewers}; -- cgit v1.2.3-24-g4f1b