From 3afcaf37c3b679c68c6f0610bd861cb80722733d Mon Sep 17 00:00:00 2001 From: Gervase Markham Date: Mon, 11 May 2015 18:38:55 +0100 Subject: Bug 751862 - Make it so people inactive in last 60 days can't be asked for review and aren't suggested. r=glob --- .../Review/template/en/default/hook/global/header-start.html.tmpl | 1 + .../template/en/default/hook/global/user-error-errors.html.tmpl | 6 ++++++ 2 files changed, 7 insertions(+) (limited to 'extensions/Review/template/en/default/hook') diff --git a/extensions/Review/template/en/default/hook/global/header-start.html.tmpl b/extensions/Review/template/en/default/hook/global/header-start.html.tmpl index a1ced8108..8bc72ecdb 100644 --- a/extensions/Review/template/en/default/hook/global/header-start.html.tmpl +++ b/extensions/Review/template/en/default/hook/global/header-start.html.tmpl @@ -43,6 +43,7 @@ review_suggestions = { _mentors: [ [% FOREACH u = mentors %] + [% NEXT IF NOT u.is_active %] [% PROCESS reviewer %][% "," UNLESS loop.last %] [% END %] ], diff --git a/extensions/Review/template/en/default/hook/global/user-error-errors.html.tmpl b/extensions/Review/template/en/default/hook/global/user-error-errors.html.tmpl index 112751076..aafdb5445 100644 --- a/extensions/Review/template/en/default/hook/global/user-error-errors.html.tmpl +++ b/extensions/Review/template/en/default/hook/global/user-error-errors.html.tmpl @@ -10,6 +10,12 @@ [% title = "Reviewer Required" %] You must provide a reviewer for review requests. +[% ELSIF error == "reviewer_inactive" %] + [% title = "Reviewer Is Inactive" %] + You can't ask [% reviewer.identity FILTER html %] for a review + because they have not logged in to [% terms.Bugzilla %] within the last + [%+ timeout FILTER none %] days. + [% ELSIF error == "reviewer_suggestions_param_required" %] [% title = "Parameter Required" %] You must provide either a bug_id, or a product (and optionally a -- cgit v1.2.3-24-g4f1b