From bb2b65b5d51cdbb022543d4e16a57005dff33eb2 Mon Sep 17 00:00:00 2001 From: Byron Jones Date: Fri, 2 Aug 2013 14:14:46 +0800 Subject: Bug 896320: increase the visibility of review suggestions (report, webservice) --- .../hook/global/user-error-errors.html.tmpl | 6 ++ .../en/default/hook/reports/menu-end.html.tmpl | 16 +++++ .../en/default/pages/review_suggestions.html.tmpl | 76 ++++++++++++++++++++++ 3 files changed, 98 insertions(+) create mode 100644 extensions/Review/template/en/default/hook/reports/menu-end.html.tmpl create mode 100644 extensions/Review/template/en/default/pages/review_suggestions.html.tmpl (limited to 'extensions/Review/template/en') diff --git a/extensions/Review/template/en/default/hook/global/user-error-errors.html.tmpl b/extensions/Review/template/en/default/hook/global/user-error-errors.html.tmpl index 4265f4b32..856ff3c75 100644 --- a/extensions/Review/template/en/default/hook/global/user-error-errors.html.tmpl +++ b/extensions/Review/template/en/default/hook/global/user-error-errors.html.tmpl @@ -9,4 +9,10 @@ [% IF error == "reviewer_required" %] [% title = "Reviewer Required" %] You must provide a reviewer for review requests. + +[% ELSIF error == "reviewer_suggestions_param_required" %] + [% title = "Parameter Required" %] + You must provide either a bug_id, or a product (and optionally a + component). + [% END %] diff --git a/extensions/Review/template/en/default/hook/reports/menu-end.html.tmpl b/extensions/Review/template/en/default/hook/reports/menu-end.html.tmpl new file mode 100644 index 000000000..7396e4fcb --- /dev/null +++ b/extensions/Review/template/en/default/hook/reports/menu-end.html.tmpl @@ -0,0 +1,16 @@ +[%# This Source Code Form is subject to the terms of the Mozilla Public + # License, v. 2.0. If a copy of the MPL was not distributed with this + # file, You can obtain one at http://mozilla.org/MPL/2.0/. + # + # This Source Code Form is "Incompatible With Secondary Licenses", as + # defined by the Mozilla Public License, v. 2.0. + #%] + + + diff --git a/extensions/Review/template/en/default/pages/review_suggestions.html.tmpl b/extensions/Review/template/en/default/pages/review_suggestions.html.tmpl new file mode 100644 index 000000000..5d9132e40 --- /dev/null +++ b/extensions/Review/template/en/default/pages/review_suggestions.html.tmpl @@ -0,0 +1,76 @@ +[%# This Source Code Form is subject to the terms of the Mozilla Public + # License, v. 2.0. If a copy of the MPL was not distributed with this + # file, You can obtain one at http://mozilla.org/MPL/2.0/. + # + # This Source Code Form is "Incompatible With Secondary Licenses", as + # defined by the Mozilla Public License, v. 2.0. + #%] + +[% INCLUDE global/header.html.tmpl + title = "Suggested Reviewers Report" + style_urls = [ "extensions/BMO/web/styles/reports.css", + "extensions/Review/web/styles/reports.css" ] +%] + +Products: + + +Request a change + + + + + + + + +[% FOREACH product = products %] + + + + + [% row_class = "report_row_even" %] + [% FOREACH component = product.components %] + + + + + [% row_class = row_class == "report_row_even" ? "report_row_odd" : "report_row_even" %] + [% END %] + [% IF product.reviewers.size %] + + + + + [% row_class = row_class == "report_row_even" ? "report_row_odd" : "report_row_even" %] + [% END %] +[% END %] + +
Product/ComponentSuggested Reviewers
+ + [% product.name FILTER html %] + + +
[% component.name FILTER html %] + [% FOREACH reviewer = component.reviewers %] + + [% reviewer.email FILTER html %] + [% ", " UNLESS loop.last %] + [% END %] +
All [% product.components.size ? "other" : "" %] components + [% FOREACH reviewer = product.reviewers %] + + [% reviewer.email FILTER html %] + [% ", " UNLESS loop.last %] + [% END %] +
+ +[% INCLUDE global/footer.html.tmpl %] -- cgit v1.2.3-24-g4f1b