From 07f5353454ce64657544640eca84dd06769dd8a3 Mon Sep 17 00:00:00 2001 From: Byron Jones Date: Fri, 6 Dec 2013 09:24:33 -0800 Subject: Bug 942029: review suggestions only shows the first mentor --- extensions/Review/web/js/review.js | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) (limited to 'extensions/Review/web/js') diff --git a/extensions/Review/web/js/review.js b/extensions/Review/web/js/review.js index 6d0e24342..08ae29547 100644 --- a/extensions/Review/web/js/review.js +++ b/extensions/Review/web/js/review.js @@ -107,8 +107,8 @@ var REVIEW = { // build review list if (field.component != component) { field.menu.clearContent(); - if (review_suggestions._mentor) { - REVIEW.add_menu_item(field_idx, review_suggestions._mentor, true); + for (var i = 0, il = review_suggestions._mentors.length; i < il; i++) { + REVIEW.add_menu_item(field_idx, review_suggestions._mentors[i], true); } if (review_suggestions[component] && review_suggestions[component].length) { REVIEW.add_menu_items(field_idx, review_suggestions[component]); @@ -129,6 +129,12 @@ var REVIEW = { add_menu_item: function(field_idx, user, is_mentor) { var menu = REVIEW.fields[field_idx].menu; + var items = menu.getItems(); + for (var i = 0, il = items.length; i < il; i++) { + if (items[i].cfg.config.url.value == '#' + user.login) { + return; + } + } var queue = ''; if (user.review_count == 0) { queue = 'empty queue'; -- cgit v1.2.3-24-g4f1b