From bb4b3f6727496aba5ba2633edc5fbc6746031465 Mon Sep 17 00:00:00 2001 From: Byron Jones Date: Thu, 5 Feb 2015 00:50:52 +0800 Subject: Bug 1129183: 500 internal server error with duplicate mentor field --- extensions/Review/Extension.pm | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'extensions/Review') diff --git a/extensions/Review/Extension.pm b/extensions/Review/Extension.pm index d7498f18a..9eb831071 100644 --- a/extensions/Review/Extension.pm +++ b/extensions/Review/Extension.pm @@ -139,7 +139,9 @@ sub object_validators { sub _bug_check_bug_mentors { my ($self, $value) = @_; + my %seen; return [ + grep { !$seen{$_->id}++ } map { Bugzilla::User->check({ name => $_, cache => 1 }) } ref($value) ? @$value : ($value) ]; @@ -267,7 +269,9 @@ sub _new_users_from_input { return [] unless $input_params->{$field}; Bugzilla::User::match_field({ $field => {'type' => 'multi'} });; my $value = $input_params->{$field}; + my %seen; return [ + grep { !$seen{$_->id}++ } map { Bugzilla::User->check({ name => $_, cache => 1 }) } ref($value) ? @$value : ($value) ]; -- cgit v1.2.3-24-g4f1b