From e3194040ce6433ee38775e9a0e2cd1af37b41886 Mon Sep 17 00:00:00 2001 From: Byron Jones Date: Tue, 10 Mar 2015 22:23:15 +0800 Subject: Bug 1141518: error when setting "block needinfo" or "block review requests" --- extensions/Review/Extension.pm | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) (limited to 'extensions/Review') diff --git a/extensions/Review/Extension.pm b/extensions/Review/Extension.pm index ab15e8a7b..07f1f66c0 100644 --- a/extensions/Review/Extension.pm +++ b/extensions/Review/Extension.pm @@ -639,15 +639,12 @@ sub user_preferences { && $args->{save_changes}; my $input = Bugzilla->input_params; - my $dbh = Bugzilla->dbh; my $settings = Bugzilla->user->settings; - $dbh->bz_start_transaction(); my $value = $input->{block_reviews} ? 'on' : 'off'; - my $setting = Bugzilla::User::Setting->new('block_reviews'); - $setting->validate_value($value); - $settings->{'block_reviews'}->set($value); - $dbh->bz_commit_transaction(); + $settings->{block_reviews}->validate_value($value); + $settings->{block_reviews}->set($value); + clear_settings_cache(Bugzilla->user->id); } sub page_before_template { -- cgit v1.2.3-24-g4f1b