From 37aef45426f4b831bbced64783568f8104b42dcb Mon Sep 17 00:00:00 2001 From: Dave Lawrence Date: Tue, 3 Sep 2013 17:57:42 -0400 Subject: Bug 912232 - Show tracking flag bug counts in tracking flag list as well as on the edit page --- extensions/TrackingFlags/lib/Flag.pm | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) (limited to 'extensions/TrackingFlags/lib/Flag.pm') diff --git a/extensions/TrackingFlags/lib/Flag.pm b/extensions/TrackingFlags/lib/Flag.pm index f35b661eb..26780a2b1 100644 --- a/extensions/TrackingFlags/lib/Flag.pm +++ b/extensions/TrackingFlags/lib/Flag.pm @@ -223,7 +223,7 @@ sub remove_from_db { } # Check to see if tracking_flags_bugs table has records - if ($self->has_bug_values) { + if ($self->bug_count) { ThrowUserError('tracking_flag_has_contents', { flag => $self }); } @@ -396,15 +396,14 @@ sub bug_flag { return $self->{'bug_flag'} = Bugzilla::Extension::TrackingFlags::Flag::Bug->new($params); } -sub has_bug_values { +sub bug_count { my ($self) = @_; - return $self->{'has_bug_values'} if defined $self->{'has_bug_values'}; + return $self->{'bug_count'} if defined $self->{'bug_count'}; my $dbh = Bugzilla->dbh; - return $self->{'has_bug_values'} = scalar $dbh->selectrow_array(" - SELECT 1 + return $self->{'bug_count'} = scalar $dbh->selectrow_array(" + SELECT COUNT(bug_id) FROM tracking_flags_bugs - WHERE tracking_flag_id = ? " . - $dbh->sql_limit(1), + WHERE tracking_flag_id = ?", undef, $self->flag_id); } -- cgit v1.2.3-24-g4f1b