From 46ab4b8a85d62bc7b06c1d84c5e9553f9fade0ae Mon Sep 17 00:00:00 2001
From: Byron Jones <bjones@mozilla.com>
Date: Tue, 15 Oct 2013 23:15:48 +0800
Subject: Bug 926842: unable to change status and tracking flag values once
 they are set

---
 extensions/TrackingFlags/Extension.pm | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

(limited to 'extensions/TrackingFlags')

diff --git a/extensions/TrackingFlags/Extension.pm b/extensions/TrackingFlags/Extension.pm
index 3628ef8f5..455afdd1f 100644
--- a/extensions/TrackingFlags/Extension.pm
+++ b/extensions/TrackingFlags/Extension.pm
@@ -492,8 +492,8 @@ sub object_end_of_set_all {
 
     foreach my $flag (@$tracking_flags) {
         my $flag_name = $flag->name;
-        if (defined $params->{$flag_name}) {
-            $object->{$flag_name} = $params->{$flag_name};
+        if (exists $params->{$flag_name}) {
+            $object->set($flag_name, $params->{$flag_name});
         }
     }
 }
@@ -516,8 +516,6 @@ sub bug_end_of_update {
         my $new_value = $bug->$flag_name;
         my $old_value = $old_bug->$flag_name;
 
-        next if $new_value eq $old_value;
-
         if ($new_value ne $old_value) {
             # Do not allow if the user cannot set the old value or the new value
             if (!$flag->can_set_value($new_value)) {
-- 
cgit v1.2.3-24-g4f1b