From 0b899217cfa4e900c860f7898c8e67b701072f73 Mon Sep 17 00:00:00 2001 From: Matt Selsky Date: Wed, 18 Apr 2012 10:26:32 -0300 Subject: Bug 731727: Add support for RT to MoreBugUrl extension r=timello, a=LpSolit --- extensions/MoreBugUrl/Extension.pm | 1 + extensions/MoreBugUrl/lib/RT.pm | 37 ++++++++++++++++++++++ .../user-error-bug_url_invalid_tracker.html.tmpl | 1 + 3 files changed, 39 insertions(+) create mode 100644 extensions/MoreBugUrl/lib/RT.pm (limited to 'extensions') diff --git a/extensions/MoreBugUrl/Extension.pm b/extensions/MoreBugUrl/Extension.pm index 715316585..1ec2fcf16 100644 --- a/extensions/MoreBugUrl/Extension.pm +++ b/extensions/MoreBugUrl/Extension.pm @@ -12,6 +12,7 @@ use base qw(Bugzilla::Extension); use constant MORE_SUB_CLASSES => qw( Bugzilla::Extension::MoreBugUrl::ReviewBoard Bugzilla::Extension::MoreBugUrl::Rietveld + Bugzilla::Extension::MoreBugUrl::RT ); # We need to update bug_see_also table because both diff --git a/extensions/MoreBugUrl/lib/RT.pm b/extensions/MoreBugUrl/lib/RT.pm new file mode 100644 index 000000000..0d5faa2a8 --- /dev/null +++ b/extensions/MoreBugUrl/lib/RT.pm @@ -0,0 +1,37 @@ +# This Source Code Form is subject to the terms of the Mozilla Public +# License, v. 2.0. If a copy of the MPL was not distributed with this +# file, You can obtain one at http://mozilla.org/MPL/2.0/. +# +# This Source Code Form is "Incompatible With Secondary Licenses", as +# defined by the Mozilla Public License, v. 2.0. + +package Bugzilla::Extension::MoreBugUrl::RT; +use strict; +use base qw(Bugzilla::BugUrl); + +############################### +#### Methods #### +############################### + +sub should_handle { + my ($class, $uri) = @_; + + # RT URLs can look like various things: + # http://example.com/rt/Ticket/Display.html?id=1234 + # https://example.com/Public/Bug/Display.html?id=1234 + return ($uri->path =~ m|/Display.html$| + and $uri->query_param('id') =~ /^\d+$/) ? 1 : 0; +} + +sub _check_value { + my $class = shift; + + my $uri = $class->SUPER::_check_value(@_); + + # And remove any # part if there is one. + $uri->fragment(undef); + + return $uri; +} + +1; diff --git a/extensions/MoreBugUrl/template/en/default/hook/global/user-error-bug_url_invalid_tracker.html.tmpl b/extensions/MoreBugUrl/template/en/default/hook/global/user-error-bug_url_invalid_tracker.html.tmpl index e0cf6be8e..979a9d5dd 100644 --- a/extensions/MoreBugUrl/template/en/default/hook/global/user-error-bug_url_invalid_tracker.html.tmpl +++ b/extensions/MoreBugUrl/template/en/default/hook/global/user-error-bug_url_invalid_tracker.html.tmpl @@ -8,3 +8,4 @@
  • A Review Board review request.
  • An issue in a Rietveld installation.
  • +
  • A ticket in an RT installation.
  • -- cgit v1.2.3-24-g4f1b