From 86fb87f1a65a17e7a86fe71b06d57767b0b3ea3b Mon Sep 17 00:00:00 2001 From: Frédéric Buclin Date: Mon, 29 Feb 2016 19:34:34 +0100 Subject: Bug 1136137: Require Perl 5.14 r=dkl --- extensions/BmpConvert/Config.pm | 2 +- extensions/BmpConvert/Extension.pm | 2 +- extensions/Example/API/1_0/Resource/Example.pm | 2 +- extensions/Example/Config.pm | 2 +- extensions/Example/Extension.pm | 10 ++-------- extensions/Example/lib/Auth/Login.pm | 2 +- extensions/Example/lib/Auth/Verify.pm | 2 +- extensions/Example/lib/Config.pm | 2 +- extensions/Example/lib/Migrate/ImportBugs.pm | 6 +++++- extensions/Example/lib/Util.pm | 2 +- extensions/Example/lib/WebService.pm | 2 +- extensions/MoreBugUrl/Config.pm | 2 +- extensions/MoreBugUrl/Extension.pm | 2 +- extensions/MoreBugUrl/lib/BitBucket.pm | 2 +- extensions/MoreBugUrl/lib/GetSatisfaction.pm | 2 +- extensions/MoreBugUrl/lib/PHP.pm | 2 +- extensions/MoreBugUrl/lib/Phabricator.pm | 2 +- extensions/MoreBugUrl/lib/RT.pm | 2 +- extensions/MoreBugUrl/lib/Redmine.pm | 2 +- extensions/MoreBugUrl/lib/ReviewBoard.pm | 2 +- extensions/MoreBugUrl/lib/Rietveld.pm | 2 +- extensions/MoreBugUrl/lib/Savane.pm | 2 +- extensions/Voting/Config.pm | 2 +- extensions/Voting/Extension.pm | 2 +- extensions/create.pl | 2 +- 25 files changed, 30 insertions(+), 32 deletions(-) (limited to 'extensions') diff --git a/extensions/BmpConvert/Config.pm b/extensions/BmpConvert/Config.pm index 4984f19a9..3c8e792ab 100644 --- a/extensions/BmpConvert/Config.pm +++ b/extensions/BmpConvert/Config.pm @@ -7,7 +7,7 @@ package Bugzilla::Extension::BmpConvert; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/extensions/BmpConvert/Extension.pm b/extensions/BmpConvert/Extension.pm index b8201f106..407ab3aaa 100644 --- a/extensions/BmpConvert/Extension.pm +++ b/extensions/BmpConvert/Extension.pm @@ -7,7 +7,7 @@ package Bugzilla::Extension::BmpConvert; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/extensions/Example/API/1_0/Resource/Example.pm b/extensions/Example/API/1_0/Resource/Example.pm index c4c5f9a32..38000fbdb 100644 --- a/extensions/Example/API/1_0/Resource/Example.pm +++ b/extensions/Example/API/1_0/Resource/Example.pm @@ -7,7 +7,7 @@ package Bugzilla::API::1_0::Resource::Example; -use 5.10.1; +use 5.14.0; use strict; use warnings; use parent qw(Bugzilla::API::1_0::Resource); diff --git a/extensions/Example/Config.pm b/extensions/Example/Config.pm index 16708e3f8..02ed01e77 100644 --- a/extensions/Example/Config.pm +++ b/extensions/Example/Config.pm @@ -7,7 +7,7 @@ package Bugzilla::Extension::Example; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/extensions/Example/Extension.pm b/extensions/Example/Extension.pm index 40ee9c2d1..ef27200ac 100644 --- a/extensions/Example/Extension.pm +++ b/extensions/Example/Extension.pm @@ -7,7 +7,7 @@ package Bugzilla::Extension::Example; -use 5.10.1; +use 5.14.0; use strict; use warnings; @@ -479,13 +479,7 @@ sub error_catch { my $new_error_msg = "Ah ah, you tried to access $page_id? Good try!"; $new_error_msg = html_quote($new_error_msg); # There are better tools to parse an HTML page, but it's just an example. - # Since Perl 5.16, we can no longer write "class" inside look-behind - # assertions, because "ss" is also seen as the german ß character, which - # makes Perl 5.16 complain. The right fix is to use the /aa modifier, - # but it's only understood since Perl 5.14. So the workaround is to write - # "clas[s]" instead of "class". Stupid and ugly hack, but it works with - # all Perl versions. - $$page =~ s/(?<=).*(?=<\/td>)/$new_error_msg/si; + $$page =~ s/
\K(.*)/$new_error_msg
$1/siaa; } sub flag_end_of_update { diff --git a/extensions/Example/lib/Auth/Login.pm b/extensions/Example/lib/Auth/Login.pm index 15c58a881..77a113722 100644 --- a/extensions/Example/lib/Auth/Login.pm +++ b/extensions/Example/lib/Auth/Login.pm @@ -7,7 +7,7 @@ package Bugzilla::Extension::Example::Auth::Login; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/extensions/Example/lib/Auth/Verify.pm b/extensions/Example/lib/Auth/Verify.pm index 49fd9fbb7..8cda4a9e8 100644 --- a/extensions/Example/lib/Auth/Verify.pm +++ b/extensions/Example/lib/Auth/Verify.pm @@ -7,7 +7,7 @@ package Bugzilla::Extension::Example::Auth::Verify; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/extensions/Example/lib/Config.pm b/extensions/Example/lib/Config.pm index fac0046af..311ea4a6a 100644 --- a/extensions/Example/lib/Config.pm +++ b/extensions/Example/lib/Config.pm @@ -7,7 +7,7 @@ package Bugzilla::Extension::Example::Config; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/extensions/Example/lib/Migrate/ImportBugs.pm b/extensions/Example/lib/Migrate/ImportBugs.pm index 42a393c73..3160c91a8 100644 --- a/extensions/Example/lib/Migrate/ImportBugs.pm +++ b/extensions/Example/lib/Migrate/ImportBugs.pm @@ -18,8 +18,12 @@ implementation see L. =cut package Bugzilla::Extension::Example::Migrate::ImportBugs; + +use 5.14.0 use strict; -use base qw(Bugzilla::Migrate); +use warnings; + +use parent qw(Bugzilla::Migrate); use Bugzilla::Constants; use Bugzilla::Install::Util qw(indicate_progress); diff --git a/extensions/Example/lib/Util.pm b/extensions/Example/lib/Util.pm index ccc349c9c..88a9a5a84 100644 --- a/extensions/Example/lib/Util.pm +++ b/extensions/Example/lib/Util.pm @@ -7,7 +7,7 @@ package Bugzilla::Extension::Example::Util; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/extensions/Example/lib/WebService.pm b/extensions/Example/lib/WebService.pm index d8a96b5f5..4dc7dd2e5 100644 --- a/extensions/Example/lib/WebService.pm +++ b/extensions/Example/lib/WebService.pm @@ -7,7 +7,7 @@ package Bugzilla::Extension::Example::WebService; -use 5.10.1; +use 5.14.0; use strict; use warnings; use parent qw(Bugzilla::WebService); diff --git a/extensions/MoreBugUrl/Config.pm b/extensions/MoreBugUrl/Config.pm index e0eac5f8a..a93f350ff 100644 --- a/extensions/MoreBugUrl/Config.pm +++ b/extensions/MoreBugUrl/Config.pm @@ -7,7 +7,7 @@ package Bugzilla::Extension::MoreBugUrl; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/extensions/MoreBugUrl/Extension.pm b/extensions/MoreBugUrl/Extension.pm index 0a4223e19..d5fd661f6 100644 --- a/extensions/MoreBugUrl/Extension.pm +++ b/extensions/MoreBugUrl/Extension.pm @@ -7,7 +7,7 @@ package Bugzilla::Extension::MoreBugUrl; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/extensions/MoreBugUrl/lib/BitBucket.pm b/extensions/MoreBugUrl/lib/BitBucket.pm index dcc85992d..8b01f0bb1 100644 --- a/extensions/MoreBugUrl/lib/BitBucket.pm +++ b/extensions/MoreBugUrl/lib/BitBucket.pm @@ -7,7 +7,7 @@ package Bugzilla::Extension::MoreBugUrl::BitBucket; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/extensions/MoreBugUrl/lib/GetSatisfaction.pm b/extensions/MoreBugUrl/lib/GetSatisfaction.pm index 74951735b..f50160e89 100644 --- a/extensions/MoreBugUrl/lib/GetSatisfaction.pm +++ b/extensions/MoreBugUrl/lib/GetSatisfaction.pm @@ -7,7 +7,7 @@ package Bugzilla::Extension::MoreBugUrl::GetSatisfaction; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/extensions/MoreBugUrl/lib/PHP.pm b/extensions/MoreBugUrl/lib/PHP.pm index 6f201d7b1..0cca7262f 100644 --- a/extensions/MoreBugUrl/lib/PHP.pm +++ b/extensions/MoreBugUrl/lib/PHP.pm @@ -7,7 +7,7 @@ package Bugzilla::Extension::MoreBugUrl::PHP; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/extensions/MoreBugUrl/lib/Phabricator.pm b/extensions/MoreBugUrl/lib/Phabricator.pm index 818d9af8f..c282b1bda 100644 --- a/extensions/MoreBugUrl/lib/Phabricator.pm +++ b/extensions/MoreBugUrl/lib/Phabricator.pm @@ -7,7 +7,7 @@ package Bugzilla::Extension::MoreBugUrl::Phabricator; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/extensions/MoreBugUrl/lib/RT.pm b/extensions/MoreBugUrl/lib/RT.pm index acb90cf39..d25813e4b 100644 --- a/extensions/MoreBugUrl/lib/RT.pm +++ b/extensions/MoreBugUrl/lib/RT.pm @@ -7,7 +7,7 @@ package Bugzilla::Extension::MoreBugUrl::RT; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/extensions/MoreBugUrl/lib/Redmine.pm b/extensions/MoreBugUrl/lib/Redmine.pm index 57a071239..5be0e25a0 100644 --- a/extensions/MoreBugUrl/lib/Redmine.pm +++ b/extensions/MoreBugUrl/lib/Redmine.pm @@ -7,7 +7,7 @@ package Bugzilla::Extension::MoreBugUrl::Redmine; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/extensions/MoreBugUrl/lib/ReviewBoard.pm b/extensions/MoreBugUrl/lib/ReviewBoard.pm index af5ff0684..d4691f7a0 100644 --- a/extensions/MoreBugUrl/lib/ReviewBoard.pm +++ b/extensions/MoreBugUrl/lib/ReviewBoard.pm @@ -7,7 +7,7 @@ package Bugzilla::Extension::MoreBugUrl::ReviewBoard; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/extensions/MoreBugUrl/lib/Rietveld.pm b/extensions/MoreBugUrl/lib/Rietveld.pm index a4bf08492..4587c57b9 100644 --- a/extensions/MoreBugUrl/lib/Rietveld.pm +++ b/extensions/MoreBugUrl/lib/Rietveld.pm @@ -7,7 +7,7 @@ package Bugzilla::Extension::MoreBugUrl::Rietveld; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/extensions/MoreBugUrl/lib/Savane.pm b/extensions/MoreBugUrl/lib/Savane.pm index 5b35bbf7d..722d58bbc 100644 --- a/extensions/MoreBugUrl/lib/Savane.pm +++ b/extensions/MoreBugUrl/lib/Savane.pm @@ -7,7 +7,7 @@ package Bugzilla::Extension::MoreBugUrl::Savane; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/extensions/Voting/Config.pm b/extensions/Voting/Config.pm index 97c44933e..0fd8f37c3 100644 --- a/extensions/Voting/Config.pm +++ b/extensions/Voting/Config.pm @@ -7,7 +7,7 @@ package Bugzilla::Extension::Voting; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/extensions/Voting/Extension.pm b/extensions/Voting/Extension.pm index b125933ce..a0ed8f3fd 100644 --- a/extensions/Voting/Extension.pm +++ b/extensions/Voting/Extension.pm @@ -7,7 +7,7 @@ package Bugzilla::Extension::Voting; -use 5.10.1; +use 5.14.0; use strict; use warnings; diff --git a/extensions/create.pl b/extensions/create.pl index f22734777..2f6f4a0be 100755 --- a/extensions/create.pl +++ b/extensions/create.pl @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use 5.10.1; +use 5.14.0; use strict; use warnings; -- cgit v1.2.3-24-g4f1b