From dc987268a6971eef1c17b4cadd2b61ad1ecc8d1a Mon Sep 17 00:00:00 2001
From: Dave Lawrence <dlawrence@mozilla.com>
Date: Mon, 17 Sep 2012 13:35:41 -0400
Subject: Bug 778731 - Add email flag to NEEDINFO state - Minor update

---
 extensions/Needinfo/Extension.pm | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

(limited to 'extensions')

diff --git a/extensions/Needinfo/Extension.pm b/extensions/Needinfo/Extension.pm
index 4ffabcb55..e47b3ed02 100644
--- a/extensions/Needinfo/Extension.pm
+++ b/extensions/Needinfo/Extension.pm
@@ -142,18 +142,18 @@ sub bug_end_of_update {
         my ($removed, $added) = Bugzilla::Flag->update_flags($bug, $old_bug, $timestamp);
         if ($removed || $added) {
             my $field = 'flagtypes.name';
-            $removed ||= '';
-            $added ||= '';
+            $removed = defined $removed ? $removed : '';
+            $added = defined $added ? $added : '';
             LogActivityEntry($bug->id, $field, $removed, $added, $user->id, $timestamp);
 
             # Do not overwrite other flag changes
             if ($changes->{$field}) {
-                if ($changes->{$field}->[0]) {
-                    $removed = $changes->{$field}->[0] . ",$removed";
-                }
-                if ($changes->{$field}->[1]) {
-                    $added = $changes->{$field}->[1] . ",$added";
-                }
+                $removed = defined $changes->{$field}->[0]
+                           ? $changes->{$field}->[0] . ", $removed"
+                           : $removed;
+                $added = defined $changes->{$field}->[1]
+                         ? $changes->{$field}->[1] . ", $added"
+                         : $added;
             }
             $changes->{$field} = [$removed, $added];
         }
-- 
cgit v1.2.3-24-g4f1b