From 61890499431396f3209e0a135122a1af507364f6 Mon Sep 17 00:00:00 2001
From: "bbaetz%student.usyd.edu.au" <>
Date: Sat, 10 Aug 2002 14:34:16 +0000
Subject: Bug 161865 - GetFieldID shouldn't INSERT into the fielddefs table
 r=joel x2

---
 globals.pl | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

(limited to 'globals.pl')

diff --git a/globals.pl b/globals.pl
index ec57bffb2..cdaf84512 100644
--- a/globals.pl
+++ b/globals.pl
@@ -349,12 +349,7 @@ sub GetFieldID {
     my ($f) = (@_);
     SendSQL("SELECT fieldid FROM fielddefs WHERE name = " . SqlQuote($f));
     my $fieldid = FetchOneColumn();
-    if (!$fieldid) {
-        my $q = SqlQuote($f);
-        SendSQL("REPLACE INTO fielddefs (name, description) VALUES ($q, $q)");
-        SendSQL("SELECT LAST_INSERT_ID()");
-        $fieldid = FetchOneColumn();
-    }
+    die "Unknown field id: $f" if !$fieldid;
     return $fieldid;
 }
         
-- 
cgit v1.2.3-24-g4f1b