From 9d202f2d562c0cb8299c832158811f2131c73e27 Mon Sep 17 00:00:00 2001 From: "mkanat%kerio.com" <> Date: Tue, 3 May 2005 01:52:02 +0000 Subject: Bug 289043: Implicit joins should be replaced by explicit joins - installment C Patch By Tomas Kopal r=joel, a=justdave --- globals.pl | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'globals.pl') diff --git a/globals.pl b/globals.pl index 273f677d4..d0e819f02 100644 --- a/globals.pl +++ b/globals.pl @@ -171,13 +171,14 @@ sub GenerateVersionTable { my $mpart = $dotargetmilestone ? ", milestoneurl" : ""; - SendSQL("select name, description from classifications ORDER BY name"); + SendSQL("SELECT name, description FROM classifications ORDER BY name"); while (@line = FetchSQLData()) { my ($n, $d) = (@line); $::classdesc{$n} = $d; } - SendSQL("select name, description, votesperuser, disallownew$mpart from products ORDER BY name"); + SendSQL("SELECT name, description, votesperuser, disallownew$mpart " . + "FROM products ORDER BY name"); while (@line = FetchSQLData()) { my ($p, $d, $votesperuser, $dis, $u) = (@line); $::proddesc{$p} = $d; @@ -604,7 +605,7 @@ sub DBID_to_name { } if (!defined $::cachedNameArray{$id}) { PushGlobalSQLState(); - SendSQL("select login_name from profiles where userid = $id"); + SendSQL("SELECT login_name FROM profiles WHERE userid = $id"); my $r = FetchOneColumn(); PopGlobalSQLState(); if (!defined $r || $r eq "") { -- cgit v1.2.3-24-g4f1b