From 72bdf0f920380807b1da4bb5be3523e65f618182 Mon Sep 17 00:00:00 2001 From: "lpsolit%gmail.com" <> Date: Fri, 5 Aug 2005 07:58:59 +0000 Subject: Bug 288170: importxml.pl and move.pl should not write to $datadir/maillog - Patch by Olav Vitters r=LpSolit a=justdave --- importxml.pl | 35 ----------------------------------- 1 file changed, 35 deletions(-) (limited to 'importxml.pl') diff --git a/importxml.pl b/importxml.pl index b8e017412..0d9dcb868 100755 --- a/importxml.pl +++ b/importxml.pl @@ -71,7 +71,6 @@ use Bugzilla::User; require "CGI.pl"; require "globals.pl"; -$::lockcount = 0; GetVersionTable(); @@ -117,40 +116,6 @@ sub MailMessage { my $sendmessage = $header . $message . "\n"; Bugzilla::BugMail::MessageToMTA($sendmessage); - - Log($subject . " sent to: $to"); -} - - -sub Log { - my ($str) = (@_); - Lock(); - open(FID, ">>$datadir/maillog") || die "Can't write to $datadir/maillog"; - print FID time2str("%D %H:%M", time()) . ": $str\n"; - close FID; - Unlock(); -} - -sub Lock { - if ($::lockcount <= 0) { - $::lockcount = 0; - open(LOCKFID, ">>$datadir/maillock") || die "Can't open $datadir/maillock: $!"; - my $val = flock(LOCKFID,2); - if (!$val) { # '2' is magic 'exclusive lock' const. - print Bugzilla->cgi->header(); - print "Lock failed: $val\n"; - } - chmod 0666, "$datadir/maillock"; - } - $::lockcount++; -} - -sub Unlock { - $::lockcount--; - if ($::lockcount <= 0) { - flock(LOCKFID,8); # '8' is magic 'unlock' const. - close LOCKFID; - } } -- cgit v1.2.3-24-g4f1b