From b66b079bb3ac4c736dd806b73de826faad0a8633 Mon Sep 17 00:00:00 2001 From: Koosha Khajeh Moogahi Date: Sat, 21 Apr 2012 14:46:10 +0200 Subject: Bug 349015: importxml.pl throws a warning if there is no bug status defined r/a=LpSolit --- importxml.pl | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'importxml.pl') diff --git a/importxml.pl b/importxml.pl index f7ce6e66e..9c334efa0 100755 --- a/importxml.pl +++ b/importxml.pl @@ -841,7 +841,6 @@ sub process_bug { my $valid_status = check_field('bug_status', scalar $bug_fields{'bug_status'}, undef, ERR_LEVEL ); - my $is_open = is_open_state($bug_fields{'bug_status'}); my $status = $bug_fields{'bug_status'} || undef; my $resolution = $bug_fields{'resolution'} || undef; @@ -891,7 +890,7 @@ sub process_bug { if ($status) { if($valid_status){ - if($is_open){ + if (is_open_state($status)) { if ($resolution) { $err .= "Resolution set on an open status.\n"; $err .= " Dropping resolution $resolution\n"; @@ -925,7 +924,7 @@ sub process_bug { } } } - else{ # $is_open is false + else { if (!$resolution) { $err .= "Missing Resolution. Setting status to "; if($everconfirmed){ -- cgit v1.2.3-24-g4f1b