From 4e55e090eed7b6564c203caee535634c09a56920 Mon Sep 17 00:00:00 2001 From: Byron Jones Date: Wed, 5 Mar 2014 22:45:38 +0800 Subject: Bug 977137: Comment and Preview tabs need accessibility markup r=dkl, a=justdave --- js/field.js | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) (limited to 'js') diff --git a/js/field.js b/js/field.js index 670c70a86..51fd1fe86 100644 --- a/js/field.js +++ b/js/field.js @@ -994,16 +994,22 @@ function show_comment_preview(bug_id) { var Dom = YAHOO.util.Dom; var comment = document.getElementById('comment'); var preview = document.getElementById('comment_preview'); + if (!comment || !preview) return; if (Dom.hasClass('comment_preview_tab', 'active_comment_tab')) return; preview.style.width = (comment.clientWidth - 4) + 'px'; preview.style.height = comment.offsetHeight + 'px'; + var comment_tab = document.getElementById('comment_tab'); Dom.addClass(comment, 'bz_default_hidden'); - Dom.removeClass('comment_tab', 'active_comment_tab'); + Dom.removeClass(comment_tab, 'active_comment_tab'); + comment_tab.setAttribute('aria-selected', 'false'); + + var preview_tab = document.getElementById('comment_preview_tab'); Dom.removeClass(preview, 'bz_default_hidden'); - Dom.addClass('comment_preview_tab', 'active_comment_tab'); + Dom.addClass(preview_tab, 'active_comment_tab'); + preview_tab.setAttribute('aria-selected', 'true'); Dom.addClass('comment_preview_error', 'bz_default_hidden'); @@ -1054,8 +1060,13 @@ function show_comment_edit() { if (!comment || !preview) return; if (YAHOO.util.Dom.hasClass(comment, 'active_comment_tab')) return; + var preview_tab = document.getElementById('comment_preview_tab'); YAHOO.util.Dom.addClass(preview, 'bz_default_hidden'); - YAHOO.util.Dom.removeClass('comment_preview_tab', 'active_comment_tab'); + YAHOO.util.Dom.removeClass(preview_tab, 'active_comment_tab'); + preview_tab.setAttribute('aria-selected', 'false'); + + var comment_tab = document.getElementById('comment_tab'); YAHOO.util.Dom.removeClass(comment, 'bz_default_hidden'); - YAHOO.util.Dom.addClass('comment_tab', 'active_comment_tab'); + YAHOO.util.Dom.addClass(comment_tab, 'active_comment_tab'); + comment_tab.setAttribute('aria-selected', 'true'); } -- cgit v1.2.3-24-g4f1b