From 20ed8a92744b90c7b6b5eab19d0ed7e846100a5e Mon Sep 17 00:00:00 2001 From: Max Kanat-Alexander Date: Wed, 12 May 2010 23:28:30 -0700 Subject: Bug 556123: process_bug.cgi: move the setting of comments and work_time into Bugzilla::Bug::set_all r=dkl, a=mkanat --- process_bug.cgi | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) (limited to 'process_bug.cgi') diff --git a/process_bug.cgi b/process_bug.cgi index f41dc761d..956068370 100755 --- a/process_bug.cgi +++ b/process_bug.cgi @@ -322,7 +322,8 @@ if (defined $cgi->param('keywords')) { my @set_fields = qw(op_sys rep_platform priority bug_severity component target_milestone version bug_file_loc status_whiteboard short_desc - deadline remaining_time estimated_time); + deadline remaining_time estimated_time + work_time); push(@set_fields, 'assigned_to') if !$cgi->param('set_default_assignee'); push(@set_fields, 'qa_contact') if !$cgi->param('set_default_qa_contact'); my %field_translation = ( @@ -340,16 +341,16 @@ foreach my $field_name (@set_fields) { } } +if (should_set('comment')) { + $set_all_fields{comment} = { + body => scalar $cgi->param('comment'), + is_private => scalar $cgi->param('commentprivacy'), + }; +} + my @custom_fields = Bugzilla->active_custom_fields; foreach my $b (@bug_objects) { - if (should_set('comment') || $cgi->param('work_time')) { - # Add a comment as needed to each bug. This is done early because - # there are lots of things that want to check if we added a comment. - $b->add_comment(scalar($cgi->param('comment')), - { isprivate => scalar $cgi->param('commentprivacy'), - work_time => scalar $cgi->param('work_time') }); - } $b->set_all(\%set_all_fields); $b->reset_assigned_to if $cgi->param('set_default_assignee'); $b->reset_qa_contact if $cgi->param('set_default_qa_contact'); -- cgit v1.2.3-24-g4f1b