From 8ec8da0491ad89604700b3e29a227966f6d84ba1 Mon Sep 17 00:00:00 2001 From: Perl Tidy Date: Wed, 5 Dec 2018 15:38:52 -0500 Subject: no bug - reformat all the code using the new perltidy rules --- qa/t/rest_classification.t | 76 ++++++++++++++++++++++++++++++---------------- 1 file changed, 50 insertions(+), 26 deletions(-) (limited to 'qa/t/rest_classification.t') diff --git a/qa/t/rest_classification.t b/qa/t/rest_classification.t index f5485de2b..e1083e98a 100644 --- a/qa/t/rest_classification.t +++ b/qa/t/rest_classification.t @@ -17,43 +17,67 @@ use lib qw(lib ../../lib ../../local/lib/perl5); use Test::More tests => 7; use QA::REST; -my $rest = get_rest_client(); +my $rest = get_rest_client(); my $config = $rest->bz_config; -my $args = { api_key => $config->{admin_user_api_key} }; +my $args = {api_key => $config->{admin_user_api_key}}; my $params = $rest->call('parameters', $args)->{parameters}; my $use_class = $params->{useclassification}; -ok(defined($use_class), 'Classifications are ' . ($use_class ? 'enabled' : 'disabled')); +ok(defined($use_class), + 'Classifications are ' . ($use_class ? 'enabled' : 'disabled')); # Admins can always access classifications, even when they are disabled. my $class = $rest->call('classification/1', $args)->{classifications}->[0]; -ok($class->{id}, "Admin found classification '" . $class->{name} . "' with the description '" . $class->{description} . "'"); -my @products = sort map { $_->{name} } @{ $class->{products} }; -ok(scalar(@products), scalar(@products) . ' product(s) found: ' . join(', ', @products)); +ok($class->{id}, + "Admin found classification '" + . $class->{name} + . "' with the description '" + . $class->{description} + . "'"); +my @products = sort map { $_->{name} } @{$class->{products}}; +ok(scalar(@products), + scalar(@products) . ' product(s) found: ' . join(', ', @products)); $class = $rest->call('classification/Class2_QA', $args)->{classifications}->[0]; -ok($class->{id}, "Admin found classification '" . $class->{name} . "' with the description '" . $class->{description} . "'"); -@products = sort map { $_->{name} } @{ $class->{products} }; -ok(scalar(@products), scalar(@products) . ' product(s) found: ' . join(', ', @products)); +ok($class->{id}, + "Admin found classification '" + . $class->{name} + . "' with the description '" + . $class->{description} + . "'"); +@products = sort map { $_->{name} } @{$class->{products}}; +ok(scalar(@products), + scalar(@products) . ' product(s) found: ' . join(', ', @products)); if ($use_class) { - # When classifications are enabled, everybody can query classifications... - # ... including logged-out users. - $class = $rest->call('classification/1')->{classifications}->[0]; - ok($class->{id}, 'Logged-out users can access classification ' . $class->{name}); - # ... and non-admins. - $class = $rest->call('classification/1', { api_key => $config->{editbugs_user_api_key} })->{classifications}->[0]; - ok($class->{id}, 'Non-admins can access classification ' . $class->{name}); + + # When classifications are enabled, everybody can query classifications... + # ... including logged-out users. + $class = $rest->call('classification/1')->{classifications}->[0]; + ok($class->{id}, + 'Logged-out users can access classification ' . $class->{name}); + + # ... and non-admins. + $class = $rest->call('classification/1', + {api_key => $config->{editbugs_user_api_key}})->{classifications}->[0]; + ok($class->{id}, 'Non-admins can access classification ' . $class->{name}); } else { - # When classifications are disabled, only users in the 'editclassifications' - # group can access this method... - # ... logged-out users get an error. - my $error = $rest->call('classification/1', undef, undef, MUST_FAIL); - ok($error->{error} && $error->{code} == 900, - 'Logged-out users cannot query classifications when disabled: ' . $error->{message}); - # ... as well as non-admins. - $error = $rest->call('classification/1', { api_key => $config->{editbugs_user_api_key} }, undef, MUST_FAIL); - ok($error->{error} && $error->{code} == 900, - 'Non-admins cannot query classifications when disabled: ' . $error->{message}); + # When classifications are disabled, only users in the 'editclassifications' + # group can access this method... + # ... logged-out users get an error. + my $error = $rest->call('classification/1', undef, undef, MUST_FAIL); + ok( + $error->{error} && $error->{code} == 900, + 'Logged-out users cannot query classifications when disabled: ' + . $error->{message} + ); + + # ... as well as non-admins. + $error + = $rest->call('classification/1', + {api_key => $config->{editbugs_user_api_key}}, + undef, MUST_FAIL); + ok($error->{error} && $error->{code} == 900, + 'Non-admins cannot query classifications when disabled: ' . $error->{message}); } -- cgit v1.2.3-24-g4f1b