From 8ec8da0491ad89604700b3e29a227966f6d84ba1 Mon Sep 17 00:00:00 2001 From: Perl Tidy Date: Wed, 5 Dec 2018 15:38:52 -0500 Subject: no bug - reformat all the code using the new perltidy rules --- qa/t/test_milestones.t | 117 +++++++++++++++++++++++++++++++++++-------------- 1 file changed, 85 insertions(+), 32 deletions(-) (limited to 'qa/t/test_milestones.t') diff --git a/qa/t/test_milestones.t b/qa/t/test_milestones.t index e55bd5ca4..a7860879d 100644 --- a/qa/t/test_milestones.t +++ b/qa/t/test_milestones.t @@ -18,25 +18,33 @@ my ($sel, $config) = get_selenium(); # 1st step: turn on usetargetmilestone, musthavemilestoneonaccept and letsubmitterchoosemilestone. log_in($sel, $config, 'admin'); -set_parameters($sel, {'Bug Fields' => {'usetargetmilestone-on' => undef}, - 'Bug Change Policies' => {'musthavemilestoneonaccept-on' => undef, - 'letsubmitterchoosemilestone-on' => undef}, - } - ); +set_parameters( + $sel, + { + 'Bug Fields' => {'usetargetmilestone-on' => undef}, + 'Bug Change Policies' => { + 'musthavemilestoneonaccept-on' => undef, + 'letsubmitterchoosemilestone-on' => undef + }, + } +); # 2nd step: Add the milestone "2.0" (with sortkey = 10) to the TestProduct product. edit_product($sel, "TestProduct"); -$sel->click_ok("link=Edit milestones:", undef, "Go to the Edit milestones page"); +$sel->click_ok("link=Edit milestones:", undef, + "Go to the Edit milestones page"); $sel->wait_for_page_to_load(WAIT_TIME); -$sel->title_is("Select milestone of product 'TestProduct'", "Display milestones"); +$sel->title_is("Select milestone of product 'TestProduct'", + "Display milestones"); $sel->click_ok("link=Add", undef, "Go add a new milestone"); $sel->wait_for_page_to_load(WAIT_TIME); $sel->title_is("Add Milestone to Product 'TestProduct'", "Enter new milestone"); $sel->type_ok("milestone", "2.0", "Set its name to 2.0"); -$sel->type_ok("sortkey", "10", "Set its sortkey to 10"); +$sel->type_ok("sortkey", "10", "Set its sortkey to 10"); $sel->click_ok("create", undef, "Submit data"); $sel->wait_for_page_to_load(WAIT_TIME); + # If the milestone already exists, that's not a big deal. So no special action # is required in this case. $sel->title_is("Milestone Created", "Milestone Created"); @@ -44,26 +52,45 @@ $sel->title_is("Milestone Created", "Milestone Created"); # 3rd step: file a new bug, leaving the milestone alone (should fall back to the default one). file_bug_in_product($sel, "TestProduct"); -$sel->selected_label_is("component", "TestComponent", "Component already selected (no other component defined)"); -$sel->selected_label_is("target_milestone", "---", "Default milestone selected"); -$sel->selected_label_is("version", "unspecified", "Version already selected (no other version defined)"); -$sel->type_ok("short_desc", "Target Milestone left to default", "Enter bug summary"); -$sel->type_ok("comment", "Created by Selenium to test 'musthavemilestoneonaccept'", "Enter bug description"); +$sel->selected_label_is("component", "TestComponent", + "Component already selected (no other component defined)"); +$sel->selected_label_is("target_milestone", "---", + "Default milestone selected"); +$sel->selected_label_is("version", "unspecified", + "Version already selected (no other version defined)"); +$sel->type_ok( + "short_desc", + "Target Milestone left to default", + "Enter bug summary" +); +$sel->type_ok( + "comment", + "Created by Selenium to test 'musthavemilestoneonaccept'", + "Enter bug description" +); $sel->click_ok("commit", undef, "Commit bug data to post_bug.cgi"); $sel->wait_for_page_to_load(WAIT_TIME); my $bug1_id = $sel->get_value("//input[\@name='id' and \@type='hidden']"); -$sel->is_text_present_ok('has been added to the database', "Bug $bug1_id created"); +$sel->is_text_present_ok('has been added to the database', + "Bug $bug1_id created"); # 4th step: edit the bug (test musthavemilestoneonaccept ON). -$sel->select_ok("bug_status", "label=IN_PROGRESS", "Change bug status to IN_PROGRESS"); +$sel->select_ok("bug_status", "label=IN_PROGRESS", + "Change bug status to IN_PROGRESS"); $sel->click_ok("commit", undef, "Save changes"); $sel->wait_for_page_to_load(WAIT_TIME); -$sel->title_is("Milestone Required", "Change rejected: musthavemilestoneonaccept is on but the milestone selected is the default one"); -$sel->is_text_present_ok("You must select a target milestone", undef, "Display error message"); +$sel->title_is( + "Milestone Required", + "Change rejected: musthavemilestoneonaccept is on but the milestone selected is the default one" +); +$sel->is_text_present_ok("You must select a target milestone", + undef, "Display error message"); + # We cannot use go_back_ok() because we just left post_bug.cgi where data has been submitted using POST. go_to_bug($sel, $bug1_id); -$sel->select_ok("target_milestone", "label=2.0", "Select a non-default milestone"); +$sel->select_ok("target_milestone", "label=2.0", + "Select a non-default milestone"); $sel->click_ok("commit", undef, "Save changes (2nd attempt)"); $sel->wait_for_page_to_load(WAIT_TIME); $sel->is_text_present_ok("Changes submitted for bug $bug1_id"); @@ -72,14 +99,25 @@ $sel->is_text_present_ok("Changes submitted for bug $bug1_id"); file_bug_in_product($sel, "TestProduct"); $sel->select_ok("target_milestone", "label=2.0", "Set the milestone to 2.0"); -$sel->selected_label_is("component", "TestComponent", "Component already selected (no other component defined)"); -$sel->selected_label_is("version", "unspecified", "Version already selected (no other version defined)"); -$sel->type_ok("short_desc", "Target Milestone set to non-default", "Enter bug summary"); -$sel->type_ok("comment", "Created by Selenium to test 'musthavemilestoneonaccept'", "Enter bug description"); +$sel->selected_label_is("component", "TestComponent", + "Component already selected (no other component defined)"); +$sel->selected_label_is("version", "unspecified", + "Version already selected (no other version defined)"); +$sel->type_ok( + "short_desc", + "Target Milestone set to non-default", + "Enter bug summary" +); +$sel->type_ok( + "comment", + "Created by Selenium to test 'musthavemilestoneonaccept'", + "Enter bug description" +); $sel->click_ok("commit", undef, "Commit bug data to post_bug.cgi"); $sel->wait_for_page_to_load(WAIT_TIME); my $bug2_id = $sel->get_value("//input[\@name='id' and \@type='hidden']"); -$sel->is_text_present_ok('has been added to the database', "Bug $bug2_id created"); +$sel->is_text_present_ok('has been added to the database', + "Bug $bug2_id created"); # 6th step: edit the bug (test musthavemilestoneonaccept ON). @@ -115,7 +153,8 @@ $sel->click_ok("create"); $sel->wait_for_page_to_load(WAIT_TIME); $sel->title_is("Invalid Milestone Sortkey"); my $error_msg = trim($sel->get_text("error_msg")); -ok($error_msg =~ /^The sortkey '99999999999999999' is not in the range/, "Invalid sortkey"); +ok($error_msg =~ /^The sortkey '99999999999999999' is not in the range/, + "Invalid sortkey"); $sel->go_back_ok(); $sel->wait_for_page_to_load(WAIT_TIME); $sel->type_ok("sortkey", "-polu7A"); @@ -124,7 +163,8 @@ $sel->click_ok("create"); $sel->wait_for_page_to_load(WAIT_TIME); $sel->title_is("Invalid Milestone Sortkey"); $error_msg = trim($sel->get_text("error_msg")); -ok($error_msg =~ /^The sortkey '-polu7A' is not in the range/, "Invalid sortkey"); +ok($error_msg =~ /^The sortkey '-polu7A' is not in the range/, + "Invalid sortkey"); $sel->go_back_ok(); $sel->wait_for_page_to_load(WAIT_TIME); $sel->click_ok("link='TestProduct'"); @@ -133,7 +173,8 @@ $sel->title_is("Select milestone of product 'TestProduct'"); $sel->click_ok("link=Delete"); $sel->wait_for_page_to_load(WAIT_TIME); $sel->title_is("Delete Milestone of Product 'TestProduct'"); -$sel->is_text_present_ok("When you delete this milestone", undef, "Warn the user about bugs being affected"); +$sel->is_text_present_ok("When you delete this milestone", + undef, "Warn the user about bugs being affected"); $sel->click_ok("delete"); $sel->wait_for_page_to_load(WAIT_TIME); $sel->title_is("Milestone Deleted"); @@ -142,19 +183,30 @@ $sel->title_is("Milestone Deleted"); $sel->open_ok("/$config->{bugzilla_installation}/show_bug.cgi?id=$bug1_id"); $sel->title_like(qr/^$bug1_id/); -$sel->is_text_present_ok('regexp:Target Milestone:\W+---', undef, "Milestone has fallen back to the default milestone"); +$sel->is_text_present_ok('regexp:Target Milestone:\W+---', + undef, "Milestone has fallen back to the default milestone"); # 9th step: file another bug. file_bug_in_product($sel, "TestProduct"); -$sel->selected_label_is("target_milestone", "---", "Default milestone selected"); +$sel->selected_label_is("target_milestone", "---", + "Default milestone selected"); $sel->selected_label_is("component", "TestComponent"); -$sel->type_ok("short_desc", "Only one Target Milestone available", "Enter bug summary"); -$sel->type_ok("comment", "Created by Selenium to test 'musthavemilestoneonaccept'", "Enter bug description"); +$sel->type_ok( + "short_desc", + "Only one Target Milestone available", + "Enter bug summary" +); +$sel->type_ok( + "comment", + "Created by Selenium to test 'musthavemilestoneonaccept'", + "Enter bug description" +); $sel->click_ok("commit", undef, "Commit bug data to post_bug.cgi"); $sel->wait_for_page_to_load(WAIT_TIME); my $bug3_id = $sel->get_value("//input[\@name='id' and \@type='hidden']"); -$sel->is_text_present_ok('has been added to the database', "Bug $bug3_id created"); +$sel->is_text_present_ok('has been added to the database', + "Bug $bug3_id created"); # 10th step: musthavemilestoneonaccept must have no effect as there is # no other milestone available besides the default one. @@ -166,5 +218,6 @@ $sel->is_text_present_ok("Changes submitted for bug $bug3_id"); # 11th step: turn musthavemilestoneonaccept back to OFF. -set_parameters($sel, {'Bug Change Policies' => {'musthavemilestoneonaccept-off' => undef}}); +set_parameters($sel, + {'Bug Change Policies' => {'musthavemilestoneonaccept-off' => undef}}); logout($sel); -- cgit v1.2.3-24-g4f1b