From 0ca30382be83fccfc4e352096c87c56bbf8a673c Mon Sep 17 00:00:00 2001
From: "terry%netscape.com" <>
Date: Tue, 17 Nov 1998 03:43:49 +0000
Subject: Patch by Andrew Anderson <andrew@redhat.com>.  Many minor bugfixes
 and cleanup.

---
 query.cgi | 135 ++++++++++++++++++++++++++++++++------------------------------
 1 file changed, 70 insertions(+), 65 deletions(-)

(limited to 'query.cgi')

diff --git a/query.cgi b/query.cgi
index b24dee0f3..ccac365de 100755
--- a/query.cgi
+++ b/query.cgi
@@ -99,8 +99,8 @@ print "Set-Cookie: BUGLIST=
 Content-type: text/html\n\n";
 
 GetVersionTable();
-my $who = GeneratePeopleInput("assigned_to", $default{"assigned_to"});
-my $reporter = GeneratePeopleInput("reporter", $default{"reporter"});
+my $who = GeneratePeopleInput("assigned_to", 45, $default{"assigned_to"});
+my $reporter = GeneratePeopleInput("reporter", 45, $default{"reporter"});
 
 
 # Muck the "legal product" list so that the default one is always first (and
@@ -118,97 +118,102 @@ PutHeader("Bugzilla Query Page", "Query Page");
 push @::legal_resolution, "---"; # Oy, what a hack.
 
 print "
-<FORM NAME=queryForm METHOD=GET ACTION=\"buglist.cgi\">
+<FORM NAME=\"queryForm\" METHOD=\"GET\" ACTION=\"buglist.cgi\">
 
 <table>
 <tr>
-<th align=left><A HREF=\"bug_status.html\">Status</a>:</th>
-<th align=left><A HREF=\"bug_status.html\">Resolution</a>:</th>
-<th align=left><A HREF=\"bug_status.html#rep_platform\">Platform</a>:</th>
-<th align=left><A HREF=\"bug_status.html#priority\">Priority</a>:</th>
-<th align=left><A HREF=\"bug_status.html#severity\">Severity</a>:</th>
+<th align=\"left\"><A HREF=\"bug_status.html\">Status</a>:</th>
+<th align=\"left\"><A HREF=\"bug_status.html\">Resolution</a>:</th>
+<th align=\"left\"><A HREF=\"bug_status.html#rep_platform\">Platform</a>:</th>
+<th align=\"left\"><A HREF=\"bug_status.html#priority\">Priority</a>:</th>
+<th align=\"left\"><A HREF=\"bug_status.html#severity\">Severity</a>:</th>
 </tr>
 <tr>
-<td align=left valign=top>
-<SELECT NAME=\"bug_status\" MULTIPLE SIZE=7>
+<td align=\"left\" valign=\"top\">
+<SELECT NAME=\"bug_status\" MULTIPLE SIZE=\"7\">
 @{[make_options(\@::legal_bug_status, $default{'bug_status'}, $type{'bug_status'})]}
-</SELECT>
+</SELECT><P>
 </td>
-<td align=left valign=top>
-<SELECT NAME=\"resolution\" MULTIPLE SIZE=7>
+<td align=\"left\" valign=\"top\">
+<SELECT NAME=\"resolution\" MULTIPLE SIZE=\"7\">
 @{[make_options(\@::legal_resolution, $default{'resolution'}, $type{'resolution'})]}
-</SELECT>
+</SELECT><P>
 </td>
-<td align=left valign=top>
-<SELECT NAME=\"rep_platform\" MULTIPLE SIZE=7>
+<td align=\"left\" valign=\"top\">
+<SELECT NAME=\"rep_platform\" MULTIPLE SIZE=\"7\">
 @{[make_options(\@::legal_platform, $default{'rep_platform'}, $type{'rep_platform'})]}
-</SELECT>
+</SELECT><P>
 </td>
-<td align=left valign=top>
-<SELECT NAME=\"priority\" MULTIPLE SIZE=7>
+<td align=\"left\" valign=\"top\">
+<SELECT NAME=\"priority\" MULTIPLE SIZE=\"7\">
 @{[make_options(\@::legal_priority, $default{'priority'}, $type{'priority'})]}
-</SELECT>
+</SELECT><P>
 </td>
-<td align=left valign=top>
-<SELECT NAME=\"bug_severity\" MULTIPLE SIZE=7>
+<td align=\"left\" valign=\"top\">
+<SELECT NAME=\"bug_severity\" MULTIPLE SIZE=\"7\">
 @{[make_options(\@::legal_severity, $default{'bug_severity'}, $type{'bug_severity'})]}
-</SELECT>
+</SELECT><P>
 </tr>
 </table>
 
 <p>
 <TABLE>
-<TR><TD ALIGN=RIGHT><B><A HREF=\"bug_status.html#assigned_to\">Assigned To:</a></B><TD>$who
-
+  <TR>
+    <TD ALIGN=\"RIGHT\">
+      <A HREF=\"bug_status.html#assigned_to\"><B>Assigned To:</B></A>
+    <TD>$who
 <p>
-<TR><TD ALIGN=RIGHT><B>Reporter:</B><TD>$reporter
+  <TR>
+    <TD ALIGN=\"RIGHT\">
+      <A HREF=\"bug_status.html#reporter\"><B>Reporter:</B></A>
+    <TD>$reporter
 </TABLE>
-<NOBR>Changed in the last <INPUT NAME=changedin SIZE=2> days.</NOBR>
+<NOBR>Changed in the last <INPUT NAME=\"changedin\" SIZE=\"2\"> days.</NOBR>
 
 
 <P>
 
 <table>
 <tr>
-<TH ALIGN=LEFT>Program:</th>
-<TH ALIGN=LEFT>Version:</th>
-<TH ALIGN=LEFT>Component:</th>
+<TH ALIGN=\"LEFT\">Program:</th>
+<TH ALIGN=\"LEFT\">Version:</th>
+<TH ALIGN=\"LEFT\">Component:</th>
 </tr>
 <tr>
 
-<td align=left valign=top>
-<SELECT NAME=\"product\" MULTIPLE SIZE=5>
-@{[make_options(\@::legal_product, $default{'product'}, $type{'product'})]}
-</SELECT>
+<td align=\"left\" valign=\"top\">
+<SELECT NAME=\"product\" MULTIPLE SIZE=\"5\">
+@{[make_options(\@::legal_product, url_decode($default{'product'}), $type{'product'})]}
+</SELECT><P>
 </td>
 
-<td align=left valign=top>
-<SELECT NAME=\"version\" MULTIPLE SIZE=5>
+<td align=\"left\" valign=\"top\">
+<SELECT NAME=\"version\" MULTIPLE SIZE=\"5\">
 @{[make_options(\@::legal_versions, $default{'version'}, $type{'version'})]}
-</SELECT>
+</SELECT><P>
 </td>
 
-<td align=left valign=top>
-<SELECT NAME=\"component\" MULTIPLE SIZE=5>
+<td align=\"left\" valign=\"top\">
+<SELECT NAME=\"component\" MULTIPLE SIZE=\"5\">
 @{[make_options(\@::legal_components, $default{'component'}, $type{'component'})]}
-</SELECT>
+</SELECT><P>
 </td>
 
 </tr>
 </table>
 
-<table border=0>
+<table border=\"0\">
 <tr>
-<td align=right>Summary:</td>
-<td><input name=short_desc size=30></td>
-<td><input type=radio name=short_desc_type value=substr checked>Substring</td>
-<td><input type=radio name=short_desc_type value=regexp>Regexp</td>
+<td align=\"right\">Summary:</td>
+<td><input name=\"short_desc\" size=\"30\"></td>
+<td><input type=\"radio\" name=\"short_desc_type\" value=\"substr\" checked>Substring</td>
+<td><input type=\"radio\" name=\"short_desc_type\" value=\"regexp\">Regexp</td>
 </tr>
 <tr>
-<td align=right>Description:</td>
-<td><input name=long_desc size=30></td>
-<td><input type=radio name=long_desc_type value=substr checked>Substring</td>
-<td><input type=radio name=long_desc_type value=regexp>Regexp</td>
+<td align=\"right\">Description:</td>
+<td><input name=\"long_desc\" size=\"30\"></td>
+<td><input type=\"radio\" name=\"long_desc_type\" value=\"substr\" checked>Substring</td>
+<td><input type=\"radio\" name=\"long_desc_type\" value=\"regexp\">Regexp</td>
 </tr>
 </table>
 <p>
@@ -216,27 +221,27 @@ print "
 
 
 <BR>
-<INPUT TYPE=radio NAME=cmdtype VALUE=doit CHECKED> Run this query
+<INPUT TYPE=\"radio\" NAME=\"cmdtype\" VALUE=\"doit\" CHECKED> Run this query
 <BR>
 ";
 
 if ($namelist ne "") {
     print "
-<table cellspacing=0 cellpadding=0><tr>
-<td><INPUT TYPE=radio NAME=cmdtype VALUE=editnamed> Load the remembered query:</td>
-<td rowspan=3><select name=namedcmd>$namelist</select>
+<table cellspacing=\"0\" cellpadding=\"0\"><tr>
+<td><INPUT TYPE=\"radio\" NAME=\"cmdtype\" VALUE=\"editnamed\"> Load the remembered query:</td>
+<td rowspan=\"3\"><select name=\"namedcmd\">$namelist</select>
 </tr><tr>
-<td><INPUT TYPE=radio NAME=cmdtype VALUE=runnamed> Run the remembered query:</td>
+<td><INPUT TYPE=\"radio\" NAME=\"cmdtype\" VALUE=\"runnamed\"> Run the remembered query:</td>
 </tr><tr>
-<td><INPUT TYPE=radio NAME=cmdtype VALUE=forgetnamed> Forget the remembered query:</td>
+<td><INPUT TYPE=\"radio\" NAME=\"cmdtype\" VALUE=\"forgetnamed\"> Forget the remembered query:</td>
 </tr></table>"
 }
 
 print "
-<INPUT TYPE=radio NAME=cmdtype VALUE=asdefault> Remember this as the default query
+<INPUT TYPE=\"radio\" NAME=\"cmdtype\" VALUE=\"asdefault\"> Remember this as the default query
 <BR>
-<INPUT TYPE=radio NAME=cmdtype VALUE=asnamed> Remember this query, and name it:
-<INPUT TYPE=text NAME=newqueryname>
+<INPUT TYPE=\"radio\" NAME=\"cmdtype\" VALUE=\"asnamed\"> Remember this query, and name it:
+<INPUT TYPE=\"text\" NAME=\"newqueryname\">
 <BR>
 
 <NOBR><B>Sort By:</B>
@@ -247,7 +252,7 @@ print "
 </SELECT></NOBR>
 <INPUT TYPE=\"submit\" VALUE=\"Submit\">
 <INPUT TYPE=\"reset\" VALUE=\"Reset back to the default query\">
-<INPUT TYPE=hidden name=form_name VALUE=query>
+<INPUT TYPE=\"hidden\" name=\"form_name\" VALUE=\"query\">
 <BR>Give me a <A HREF=\"help.html\">clue</A> about how to use this form.
 </CENTER>
 </FORM>
@@ -257,14 +262,14 @@ print "
 
 if (defined $::COOKIE{"Bugzilla_login"}) {
     if ($::COOKIE{"Bugzilla_login"} eq Param("maintainer")) {
-        print "<a href=editparams.cgi>Edit Bugzilla operating parameters</a><br>\n";
-        print "<a href=editowners.cgi>Edit Bugzilla component owners</a><br>\n";
+        print "<a href=\"editparams.cgi\">Edit Bugzilla operating parameters</a><br>\n";
+        print "<a href=\"editowners.cgi\">Edit Bugzilla component owners</a><br>\n";
     }
-    print "<a href=relogin.cgi>Log in as someone besides <b>$::COOKIE{'Bugzilla_login'}</b></a><br>\n";
+    print "<a href=\"relogin.cgi\">Log in as someone besides <b>$::COOKIE{'Bugzilla_login'}</b></a><br>\n";
 }
-print "<a href=changepassword.cgi>Change your password.</a><br>\n";
-print "<a href=\"enter_bug.cgi\">Create a new bug.</a><br>\n";
-print "<a href=\"reports.cgi\">Bug reports</a><br>\n";
+print "<a href=\"changepassword.cgi\">Change your password.</a><br>\n";
+print "<a href=\"enter_bug.cgi\">Enter a new bug.</a><br>\n";
+print "<a href=\"reports.cgi\">Bug reports.</a><br>\n";
 
 
 
-- 
cgit v1.2.3-24-g4f1b