From 60b331bc2a1d89296f5c57df34171db3b3eca409 Mon Sep 17 00:00:00 2001
From: "gerv%gerv.net" <>
Date: Wed, 2 Oct 2002 05:41:03 +0000
Subject: Bug 163114 - Templatise all calls to DisplayError. Patch C. Patch by
 gerv; r=burnus.

---
 quips.cgi | 20 ++++----------------
 1 file changed, 4 insertions(+), 16 deletions(-)

(limited to 'quips.cgi')

diff --git a/quips.cgi b/quips.cgi
index f120e5a24..c36a09b6c 100755
--- a/quips.cgi
+++ b/quips.cgi
@@ -55,24 +55,12 @@ if ($action eq "show") {
 }
 
 if ($action eq "add") {
+    (Param('enablequips') eq "on") || ThrowUserError("no_new_quips");
+    
     # Add the quip 
     my $comment = $::FORM{"quip"};
-    if (!$comment) {
-        DisplayError("Please enter a quip in the text field.");
-        exit();
-    }
-
-    if (Param('enablequips') ne "on") {
-        ThrowUserError("no_new_quips");
-        exit();
-    }
-    
-
-    if ($comment =~ m/</) {
-        DisplayError("Sorry - for security reasons, support for HTML tags has 
-                      been turned off in quips.");
-        exit();
-    }
+    $comment || ThrowUserError("need_quip");
+    $comment !~ m/</ || ThrowUserError("no_html_in_quips");
 
     SendSQL("INSERT INTO quips (userid, quip) VALUES (". $userid . ", " . SqlQuote($comment) . ")");
 
-- 
cgit v1.2.3-24-g4f1b