From 4dabf1a9c679f06b3637d3c76e1e05aa83a6d259 Mon Sep 17 00:00:00 2001
From: Gervase Markham <gerv@mozilla.org>
Date: Wed, 21 Jan 2015 19:49:57 +0000
Subject: Bug 1079065: [SECURITY] Always use the 3 arguments form for open() to
 prevent shell code injection r=dylan,a=simon

---
 reports.cgi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'reports.cgi')

diff --git a/reports.cgi b/reports.cgi
index cdc9d4a87..89dee1c9a 100755
--- a/reports.cgi
+++ b/reports.cgi
@@ -138,7 +138,7 @@ sub generate_chart {
     my ($dir, $image_file, $product, $datasets) = @_;
     my $data_file = $dir . '/' . $product->id;
 
-    if (! open FILE, $data_file) {
+    if (!open(FILE, '<', $data_file)) {
         ThrowCodeError('chart_data_not_generated', {'product' => $product});
     }
 
-- 
cgit v1.2.3-24-g4f1b