From 393cb39fdfefff8bba165d9076723bf7048198ef Mon Sep 17 00:00:00 2001 From: "lpsolit%gmail.com" <> Date: Mon, 8 Oct 2007 04:00:03 +0000 Subject: Bug 398735: sanitycheck.cgi hardcodes bug statuses in the everconfirmed check - Patch by Frédéric Buclin r/a=mkanat MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- sanitycheck.cgi | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'sanitycheck.cgi') diff --git a/sanitycheck.cgi b/sanitycheck.cgi index 157281b11..ef92256a2 100755 --- a/sanitycheck.cgi +++ b/sanitycheck.cgi @@ -874,11 +874,11 @@ Status('bug_check_status_everconfirmed'); BugCheck("bugs WHERE bug_status = 'UNCONFIRMED' AND everconfirmed = 1", 'bug_check_status_everconfirmed_error_text'); -# The below list of resolutions is hard-coded because we don't know if future -# resolutions will be confirmed, unconfirmed or maybeconfirmed. I suspect -# they will be maybeconfirmed, e.g. ASLEEP and REMIND. This hardcoding should -# disappear when we have customized statuses. -BugCheck("bugs WHERE bug_status IN ('NEW', 'ASSIGNED', 'REOPENED') AND everconfirmed = 0", + +my @confirmed_open_states = grep {$_ ne 'UNCONFIRMED'} BUG_STATE_OPEN; +my $confirmed_open_states = join(', ', map {$dbh->quote($_)} @confirmed_open_states); + +BugCheck("bugs WHERE bug_status IN ($confirmed_open_states) AND everconfirmed = 0", 'bug_check_status_everconfirmed_error_text2'); Status('bug_check_votes_everconfirmed'); -- cgit v1.2.3-24-g4f1b