From b99cbd1d893ff0a730ab7187f409bcdf3c6f4aeb Mon Sep 17 00:00:00 2001 From: "mkanat%kerio.com" <> Date: Wed, 16 Mar 2005 08:27:14 +0000 Subject: Bug 174295: ANSI SQL requires all columns in SELECT to be in GROUP BY, unless they are in "aggregate" functions Patch By Tomas Kopal r=joel, a=myk --- sanitycheck.cgi | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'sanitycheck.cgi') diff --git a/sanitycheck.cgi b/sanitycheck.cgi index 6f85e6cfd..84f41c398 100755 --- a/sanitycheck.cgi +++ b/sanitycheck.cgi @@ -102,7 +102,8 @@ if (defined $cgi->param('rebuildvotecache')) { Status("OK, now rebuilding vote cache."); $dbh->bz_lock_tables('bugs WRITE', 'votes READ'); SendSQL("UPDATE bugs SET votes = 0"); - SendSQL("SELECT bug_id, SUM(vote_count) FROM votes GROUP BY bug_id"); + SendSQL("SELECT bug_id, SUM(vote_count) FROM votes " . + $dbh->sql_group_by('bug_id')); my %votes; while (@row = FetchSQLData()) { my ($id, $v) = (@row); @@ -482,7 +483,8 @@ while (@row = FetchSQLData()) { } Status("Checking cached vote counts"); -SendSQL("SELECT bug_id, SUM(vote_count) FROM votes GROUP BY bug_id"); +SendSQL("SELECT bug_id, SUM(vote_count) FROM votes " . + $dbh->sql_group_by('bug_id')); while (@row = FetchSQLData()) { my ($id, $v) = (@row); -- cgit v1.2.3-24-g4f1b