From 4dabf1a9c679f06b3637d3c76e1e05aa83a6d259 Mon Sep 17 00:00:00 2001 From: Gervase Markham Date: Wed, 21 Jan 2015 19:49:57 +0000 Subject: Bug 1079065: [SECURITY] Always use the 3 arguments form for open() to prevent shell code injection r=dylan,a=simon --- search_plugin.cgi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'search_plugin.cgi') diff --git a/search_plugin.cgi b/search_plugin.cgi index 7de8bed5f..0b628f32e 100755 --- a/search_plugin.cgi +++ b/search_plugin.cgi @@ -27,7 +27,7 @@ print $cgi->header('application/xml'); # Get the contents of favicon.ico my $filename = bz_locations()->{'libpath'} . "/images/favicon.ico"; -if (open(IN, $filename)) { +if (open(IN, '<', $filename)) { local $/; binmode IN; $vars->{'favicon'} = ; -- cgit v1.2.3-24-g4f1b