From 53bd4df6f142c240d7beaa6b6789839da1f5f164 Mon Sep 17 00:00:00 2001 From: "justdave%bugzilla.org" <> Date: Mon, 25 Oct 2004 14:25:58 +0000 Subject: [SECURITY] Bug 263780: Exporting a bug to XML exposes user comments and attachment summaries which are marked as private to users who are not members of the group allowed to see private comments and attachments. XML export is not exposed in the user interface, but is available to anyone who knows the correct URL to invoke it. This only affects sites that use the 'insidergroup' feature. Patch by Joel Peshkin r=vladd,justdave, a=justdave --- show_bug.cgi | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'show_bug.cgi') diff --git a/show_bug.cgi b/show_bug.cgi index 4803ff67b..03cf6f60d 100755 --- a/show_bug.cgi +++ b/show_bug.cgi @@ -113,6 +113,10 @@ if ($cgi->param("field")) { @fieldlist = $cgi->param("field"); } +unless (UserInGroup(Param("timetrackinggroup"))) { + @fieldlist = grep($_ !~ /_time$/, @fieldlist); +} + foreach (@fieldlist) { $displayfields{$_} = 1; } -- cgit v1.2.3-24-g4f1b