From 8feb85e10f0993bdb372d500223cf568bd3dd355 Mon Sep 17 00:00:00 2001 From: Byron Jones Date: Mon, 10 Feb 2014 16:05:16 +0800 Subject: Bug 961789: large dependency trees with lots of resolved bugs are very slow to load r=LpSolit, a=justdave --- showdependencytree.cgi | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) (limited to 'showdependencytree.cgi') diff --git a/showdependencytree.cgi b/showdependencytree.cgi index 786a0312d..fb8a59cc3 100755 --- a/showdependencytree.cgi +++ b/showdependencytree.cgi @@ -123,10 +123,8 @@ sub _generate_tree { _generate_tree($dep_id, $relationship, $depth + 1, $bugs, $ids); } - # remove bugs according to visiblity and filters - if (!Bugzilla->user->can_see_bug($dep_id) - || ($hide_resolved && !$bugs->{$dep_id}->isopened)) - { + # remove bugs according to visiblity + if (!Bugzilla->user->can_see_bug($dep_id)) { delete $ids->{$dep_id}; } elsif (!grep { $_ == $dep_id } @{ $bugs->{dependencies}->{$bug_id} }) { @@ -140,7 +138,7 @@ sub _get_dependencies { my $cache = Bugzilla->request_cache->{dependency_cache} ||= {}; return $cache->{$bug_id}->{$relationship} ||= $relationship eq 'dependson' - ? Bugzilla::Bug::EmitDependList('blocked', 'dependson', $bug_id) - : Bugzilla::Bug::EmitDependList('dependson', 'blocked', $bug_id); + ? Bugzilla::Bug::EmitDependList('blocked', 'dependson', $bug_id, $hide_resolved) + : Bugzilla::Bug::EmitDependList('dependson', 'blocked', $bug_id, $hide_resolved); } -- cgit v1.2.3-24-g4f1b