From f5f31fc070588c2075dd13a0fbabe8117e3aad76 Mon Sep 17 00:00:00 2001 From: "mkanat%kerio.com" <> Date: Tue, 5 Apr 2005 04:52:03 +0000 Subject: Bug 286235: Implicit joins should be replaced by explicit joins - installment A Patch By Tomas Kopal r=joel, a=myk --- showdependencytree.cgi | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) (limited to 'showdependencytree.cgi') diff --git a/showdependencytree.cgi b/showdependencytree.cgi index b373563c1..76ef0ddee 100755 --- a/showdependencytree.cgi +++ b/showdependencytree.cgi @@ -149,16 +149,17 @@ sub GetBug { my $bug = {}; if (Bugzilla->user->can_see_bug($id)) { SendSQL("SELECT 1, - bug_status, - short_desc, - $milestone_column, - assignee.userid, - assignee.login_name - FROM bugs, profiles AS assignee - WHERE bugs.bug_id = $id - AND bugs.assigned_to = assignee.userid"); - - + bug_status, + short_desc, + $milestone_column, + assignee.userid, + assignee.login_name + FROM bugs + INNER JOIN profiles AS assignee + ON bugs.assigned_to = assignee.userid + WHERE bugs.bug_id = $id"); + + ($bug->{'exists'}, $bug->{'status'}, $bug->{'summary'}, -- cgit v1.2.3-24-g4f1b