From ec4862650f2da6ef3b0cdcb1ca135a64879c6b31 Mon Sep 17 00:00:00 2001
From: Frédéric Buclin <LpSolit@gmail.com>
Date: Sun, 22 Dec 2013 15:51:18 +0100
Subject: Bug 322402: Inline styling using bgcolor=x or color=x should be
 replaced by CSS styles r/a=justdave

---
 .../admin/products/confirm-delete.html.tmpl        | 23 +++++-----------------
 template/en/default/admin/products/edit.html.tmpl  | 14 +++++--------
 .../admin/products/groupcontrol/edit.html.tmpl     |  7 ++++---
 .../admin/products/list-classifications.html.tmpl  |  1 +
 template/en/default/admin/products/list.html.tmpl  |  1 +
 5 files changed, 16 insertions(+), 30 deletions(-)

(limited to 'template/en/default/admin/products')

diff --git a/template/en/default/admin/products/confirm-delete.html.tmpl b/template/en/default/admin/products/confirm-delete.html.tmpl
index f1d6aa429..626513526 100644
--- a/template/en/default/admin/products/confirm-delete.html.tmpl
+++ b/template/en/default/admin/products/confirm-delete.html.tmpl
@@ -25,7 +25,7 @@
 %]
 
 <table border="1" cellpadding="4" cellspacing="0">
-  <tr bgcolor="#6666FF">
+  <tr class="column_header">
     <th valign="top" class="left">Field</th>
     <th valign="top" class="left">Value</th>
   </tr>
@@ -42,7 +42,7 @@
         [% IF classification.description %]
           [% classification.description FILTER html_light %]
         [% ELSE %]
-          <span style="color: red">missing</span>
+          <span class="warning">missing</span>
         [% END %]
       </td>
     </tr>
@@ -59,13 +59,7 @@
   <tr>
     <td valign="top">Description:</td>
     [%# descriptions are intentionally not filtered to allow html content %]
-    <td valign="top">
-      [% IF product.description %]
-        [% product.description FILTER html_light %]
-      [% ELSE %]
-        <span style="color: red">missing</span>
-      [% END %]
-    </td>
+    <td valign="top">[% product.description FILTER html_light %]</td>
   </tr>
 
   [% IF Param('usetargetmilestone') %]
@@ -111,14 +105,7 @@
           [% FOREACH c = product.components %]
             <tr>
               <th>[% c.name FILTER html %]:</th>
-              [%# descriptions are intentionally not filtered to allow html content %]
-              <td>
-                [% IF c.description %]
-                  [% c.description FILTER html_light %]
-                [% ELSE %]
-                  <span style="color: red">missing</span>
-                [% END %]
-              </td>
+              <td>[% c.description FILTER html_light %]</td>
             </tr>
           [% END %]
         </table>
@@ -214,7 +201,7 @@
 
   [% ELSE %]
 
-    <table border="0" cellpadding="20" width="70%" bgcolor="red">
+    <table class="confirmation">
       <tr>
         <td>
           There
diff --git a/template/en/default/admin/products/edit.html.tmpl b/template/en/default/admin/products/edit.html.tmpl
index 713f30aeb..fdbbe42c2 100644
--- a/template/en/default/admin/products/edit.html.tmpl
+++ b/template/en/default/admin/products/edit.html.tmpl
@@ -45,16 +45,12 @@
           [% FOREACH component = product.components %]
             <a href="editcomponents.cgi?action=edit&product=
             [%- product.name FILTER uri %]&component=
-            [%- component.name FILTER uri %]">[% component.name FILTER html %]</a>:&nbsp;
-            [% IF component.description %]
-              [% component.description FILTER html_light %]
-            [% ELSE %]
-              <font color="red">description missing</font>
-            [% END %]
+            [%- component.name FILTER uri %]">[% component.name FILTER html %]</a>:
+            [% component.description FILTER html_light %]
             <br>
           [% END %]
         [% ELSE %]
-          <font color="red">missing</font>
+          <span class="warning">missing</span>
         [% END %]
       </td>
     </tr>
@@ -70,7 +66,7 @@ versions:</a>
             <br>
           [% END %]
         [% ELSE %]
-          <font color="red">missing</font>
+          <span class="warning">missing</span>
         [% END %]
       </td>
     </tr>
@@ -87,7 +83,7 @@ versions:</a>
             <br>
             [% END %]
           [% ELSE %]
-            <font color="red">missing</font>
+            <span class="warning">missing</span>
           [% END %]
         </td>
       </tr>
diff --git a/template/en/default/admin/products/groupcontrol/edit.html.tmpl b/template/en/default/admin/products/groupcontrol/edit.html.tmpl
index 1ba600271..62e1439ad 100644
--- a/template/en/default/admin/products/groupcontrol/edit.html.tmpl
+++ b/template/en/default/admin/products/groupcontrol/edit.html.tmpl
@@ -10,7 +10,8 @@
     Edit Group Controls for [% product.name FILTER html %]
 [% END %]
 [% PROCESS global/header.html.tmpl 
-   title = title 
+  title = title
+  style_urls = ['skins/standard/admin.css']
 %]
 
 [% display_headers = 1 %]
@@ -24,7 +25,7 @@
       <input type="hidden" name="token" value="[% token FILTER html %]">
 
       <table id="form" cellspacing="0" cellpadding="4" border="1">
-        <tr bgcolor="#6666ff">
+        <tr class="column_header">
           <th>Group</th>
           <th>Entry</th>
           <th>MemberControl</th>
@@ -37,7 +38,7 @@
         </tr>
   [% END %]
   [% IF !group.group.isactive %]
-    <tr bgcolor="#bbbbbb">
+    <tr class="disabled">
       <td>[% group.group.name FILTER html %]</td>
       <td align="center" colspan="7">Disabled</td>
       <td>[% group.bug_count FILTER html %]</td>
diff --git a/template/en/default/admin/products/list-classifications.html.tmpl b/template/en/default/admin/products/list-classifications.html.tmpl
index ea32a0057..a13d2be0f 100644
--- a/template/en/default/admin/products/list-classifications.html.tmpl
+++ b/template/en/default/admin/products/list-classifications.html.tmpl
@@ -16,6 +16,7 @@
 
 [% PROCESS global/header.html.tmpl
   title = "Select Classification"
+  style_urls = ['skins/standard/admin.css']
 %]
 
 [% columns = [
diff --git a/template/en/default/admin/products/list.html.tmpl b/template/en/default/admin/products/list.html.tmpl
index 364cf79e9..d09a552e2 100644
--- a/template/en/default/admin/products/list.html.tmpl
+++ b/template/en/default/admin/products/list.html.tmpl
@@ -26,6 +26,7 @@
 
 [% PROCESS global/header.html.tmpl
   title = "Select product $classification_title"
+  style_urls = ['skins/standard/admin.css']
 %]
 
 [% columns = [
-- 
cgit v1.2.3-24-g4f1b