From b4aecfefc218d425c7c2b05d0878d4b062613a18 Mon Sep 17 00:00:00 2001
From: rojanu <aliustek@gmail.com>
Date: Wed, 2 Apr 2014 16:35:08 +0800
Subject: Bug 539894: Use <optgroup/> to group products into classifications in
 the product drop-down on show_bug.cgi r=glob, a=justdave

---
 template/en/default/reports/duplicates.html.tmpl | 12 +++++-------
 template/en/default/reports/old-charts.html.tmpl | 12 ++++++------
 2 files changed, 11 insertions(+), 13 deletions(-)

(limited to 'template/en/default/reports')

diff --git a/template/en/default/reports/duplicates.html.tmpl b/template/en/default/reports/duplicates.html.tmpl
index 67d1f233e..0d47aae75 100644
--- a/template/en/default/reports/duplicates.html.tmpl
+++ b/template/en/default/reports/duplicates.html.tmpl
@@ -51,13 +51,11 @@
     <tr>
       <td>Restrict to products:</td>
       <td>
-        <select name="product" size="5" multiple="multiple">
-          [% FOREACH p = user.get_selectable_products %]
-            <option name="[% p.name FILTER html %]"
-            [% ' selected="selected"' IF product.contains(p.name) %]
-            >[% p.name FILTER html %]</option>
-          [% END %]
-        </select>
+        [% INCLUDE "global/product-select.html.tmpl"
+          id       => "product"
+          name     => "product"
+          multiple => 5
+        %]
       </td>
     </tr>
 
diff --git a/template/en/default/reports/old-charts.html.tmpl b/template/en/default/reports/old-charts.html.tmpl
index b3ebe386d..acebca74d 100644
--- a/template/en/default/reports/old-charts.html.tmpl
+++ b/template/en/default/reports/old-charts.html.tmpl
@@ -7,7 +7,6 @@
   #%]
 
 [%# INTERFACE:
-  # products: an array of product names the user is allowed to view.
   # datasets: an array of hashes with available statuses and resolutions.
   # url_image: URL of the generated graph.
   #%]
@@ -29,11 +28,12 @@
         <tr>
           <th>Product:</th>
           <td>
-            <select id="product_id" name="product_id">
-              [% FOREACH product = products %]
-                <option value="[% product.id FILTER html %]">[% product.name || '-All-' FILTER html %]</option>
-              [% END %]
-            </select>
+            [% INCLUDE "global/product-select.html.tmpl"
+              id   => "product_id"
+              name => "product_id"
+              valueattribute => "id"
+              add  => "-All-"
+            %]
           </td>
         </tr>
         <tr>
-- 
cgit v1.2.3-24-g4f1b