From 9b3834764b26d0a806b72fdc3657075b7ab9c7c0 Mon Sep 17 00:00:00 2001
From: Kohei Yoshino <kohei.yoshino@gmail.com>
Date: Mon, 8 Jan 2018 09:55:43 -0500
Subject: Bug 1428642 - Fix minor bugs on new global header

* The magnifier icon on the search bar should not trigger search as reported in
   https://twitter.com/colinjoy/status/949035254949523457
* The search dropdown should show Saved Searches Edit link as suggested in my UX analysis
* Remove the CSS transition on the More Tools button for consistency. I didn't add the transition;
   it's default style for buttons
* Fix the position of the arrow/triangle on dropdown lists. An error of 1px.
* Add `user-select: none;` to `#header` https://developer.mozilla.org/en-US/docs/Web/CSS/user
  select
---
 template/en/default/global/header-search-dropdown.html.tmpl | 5 ++++-
 template/en/default/global/header.html.tmpl                 | 4 +---
 2 files changed, 5 insertions(+), 4 deletions(-)

(limited to 'template/en/default')

diff --git a/template/en/default/global/header-search-dropdown.html.tmpl b/template/en/default/global/header-search-dropdown.html.tmpl
index 590c95d31..8e79978ba 100644
--- a/template/en/default/global/header-search-dropdown.html.tmpl
+++ b/template/en/default/global/header-search-dropdown.html.tmpl
@@ -26,7 +26,10 @@
   <div id="header-search-dropdown-wrapper">
     [% IF user.showmybugslink OR user.queries.size OR user.queries_subscribed.size %]
       <section id="header-search-dropdown-saved">
-        <h3>Saved Searches</h3>
+        <header>
+          <h3>Saved Searches</h3>
+          <a href="userprefs.cgi?tab=saved-searches">Edit</a>
+        </header>
         <ul role="none">
           [% IF user.showmybugslink %][% filtered_username = user.login FILTER uri %]
             <li role="none"><a role="option" href="[% Param('mybugstemplate').replace('%userid%', filtered_username) %]">
diff --git a/template/en/default/global/header.html.tmpl b/template/en/default/global/header.html.tmpl
index 0f9646ba1..04b996e16 100644
--- a/template/en/default/global/header.html.tmpl
+++ b/template/en/default/global/header.html.tmpl
@@ -242,13 +242,11 @@
       <section class="searchbox-outer dropdown" role="combobox" aria-expanded="false" aria-haspopup="listbox"
                aria-owns="header-search-dropdown">
         <h2>Quick Search</h2>
+        <span class="icon" aria-hidden="true"></span>
         <input role="searchbox" id="quicksearch_top" class="dropdown-button" name="quicksearch" autocomplete="off"
                value="[% quicksearch FILTER html %]" placeholder="Search [% terms.Bugs %]"
                title="Enter a [% terms.bug %] number or some search terms" aria-controls="header-search-dropdown"
                aria-label="Quick Search">
-        <button type="submit" id="find_top" aria-label="Submit">
-          <span class="icon" aria-hidden="true"></span>
-        </button>
         [% PROCESS "global/header-search-dropdown.html.tmpl" %]
       </section>
     </form>
-- 
cgit v1.2.3-24-g4f1b