From 165689a71928008f2d12f9cd8228497594899c2f Mon Sep 17 00:00:00 2001 From: Sunil Joshi Date: Sun, 23 Mar 2014 01:56:29 +0100 Subject: Bug 962812: Use the "required" attribute where appropriate r=LpSolit a=justdave --- template/en/default/account/auth/login.html.tmpl | 6 +++--- template/en/default/account/create.html.tmpl | 2 +- template/en/default/account/email/confirm-new.html.tmpl | 4 ++-- template/en/default/account/email/confirm.html.tmpl | 2 +- .../en/default/account/password/set-forgotten-password.html.tmpl | 6 +++--- template/en/default/admin/classifications/edit-common.html.tmpl | 2 +- template/en/default/admin/components/edit-common.html.tmpl | 4 +++- template/en/default/admin/custom_fields/edit-common.html.tmpl | 4 ++-- template/en/default/admin/fieldvalues/create.html.tmpl | 2 +- template/en/default/admin/fieldvalues/edit.html.tmpl | 2 +- template/en/default/admin/flag-type/edit.html.tmpl | 5 +++-- template/en/default/admin/groups/create.html.tmpl | 4 ++-- template/en/default/admin/groups/edit.html.tmpl | 4 ++-- template/en/default/admin/keywords/create.html.tmpl | 3 ++- template/en/default/admin/keywords/edit.html.tmpl | 3 ++- template/en/default/admin/milestones/create.html.tmpl | 2 +- template/en/default/admin/milestones/edit.html.tmpl | 2 +- template/en/default/admin/products/create.html.tmpl | 2 +- template/en/default/admin/products/edit-common.html.tmpl | 4 ++-- template/en/default/admin/sudo.html.tmpl | 3 ++- template/en/default/admin/users/userdata.html.tmpl | 4 ++-- template/en/default/admin/versions/create.html.tmpl | 2 +- template/en/default/admin/versions/edit.html.tmpl | 2 +- template/en/default/bug/field.html.tmpl | 8 ++++---- template/en/default/global/userselect.html.tmpl | 3 +++ template/en/default/list/quips.html.tmpl | 2 +- 26 files changed, 48 insertions(+), 39 deletions(-) (limited to 'template') diff --git a/template/en/default/account/auth/login.html.tmpl b/template/en/default/account/auth/login.html.tmpl index 27c0690af..bf20edb8b 100644 --- a/template/en/default/account/auth/login.html.tmpl +++ b/template/en/default/account/auth/login.html.tmpl @@ -39,14 +39,14 @@ + [%- ' type="email"' UNLESS Param('emailsuffix') %] autofocus required> [% Param('emailsuffix') FILTER html %] - + @@ -115,7 +115,7 @@ If you have an account, but have forgotten your password, enter your login name below and submit a request to change your password.
- + diff --git a/template/en/default/account/create.html.tmpl b/template/en/default/account/create.html.tmpl index 1b5a4daa8..5711a726f 100644 --- a/template/en/default/account/create.html.tmpl +++ b/template/en/default/account/create.html.tmpl @@ -72,7 +72,7 @@ [% END %] + [%- ' type="email"' UNLESS Param('emailsuffix') %] required> [% Param('emailsuffix') FILTER html %] diff --git a/template/en/default/account/email/confirm-new.html.tmpl b/template/en/default/account/email/confirm-new.html.tmpl index ec8d5a474..095097698 100644 --- a/template/en/default/account/email/confirm-new.html.tmpl +++ b/template/en/default/account/email/confirm-new.html.tmpl @@ -38,13 +38,13 @@ : - + (minimum [% constants.USER_PASSWORD_MIN_LENGTH FILTER none %] characters) : - +   diff --git a/template/en/default/account/email/confirm.html.tmpl b/template/en/default/account/email/confirm.html.tmpl index 6fc171878..8edc7a9ba 100644 --- a/template/en/default/account/email/confirm.html.tmpl +++ b/template/en/default/account/email/confirm.html.tmpl @@ -23,7 +23,7 @@ - + diff --git a/template/en/default/account/password/set-forgotten-password.html.tmpl b/template/en/default/account/password/set-forgotten-password.html.tmpl index b203e66e9..eca11174f 100644 --- a/template/en/default/account/password/set-forgotten-password.html.tmpl +++ b/template/en/default/account/password/set-forgotten-password.html.tmpl @@ -30,17 +30,17 @@ - + + value="[% classification.name FILTER html %]" required> diff --git a/template/en/default/admin/components/edit-common.html.tmpl b/template/en/default/admin/components/edit-common.html.tmpl index 00b80baa8..72300af79 100644 --- a/template/en/default/admin/components/edit-common.html.tmpl +++ b/template/en/default/admin/components/edit-common.html.tmpl @@ -17,7 +17,7 @@ + value="[%- comp.name FILTER html %]" required> @@ -29,6 +29,7 @@ cols = 64 wrap = 'virtual' defaultcontent = comp.description + mandatory = 1 %] @@ -40,6 +41,7 @@ id => "initialowner" value => comp.default_assignee.login size => 64 + mandatory => 1 %] diff --git a/template/en/default/admin/custom_fields/edit-common.html.tmpl b/template/en/default/admin/custom_fields/edit-common.html.tmpl index f54073cfe..6c22bb81f 100644 --- a/template/en/default/admin/custom_fields/edit-common.html.tmpl +++ b/template/en/default/admin/custom_fields/edit-common.html.tmpl @@ -19,7 +19,7 @@ [% IF field %] [% field.name FILTER html %] [% ELSE %] - + [% END %] @@ -37,7 +37,7 @@ diff --git a/template/en/default/admin/fieldvalues/edit.html.tmpl b/template/en/default/admin/fieldvalues/edit.html.tmpl index dbe222590..2630fee92 100644 --- a/template/en/default/admin/fieldvalues/edit.html.tmpl +++ b/template/en/default/admin/fieldvalues/edit.html.tmpl @@ -32,7 +32,7 @@ [% ELSE %] + value="[% value.name FILTER html %]" required> [% END %] diff --git a/template/en/default/admin/flag-type/edit.html.tmpl b/template/en/default/admin/flag-type/edit.html.tmpl index e52d58a9a..4ee4a999c 100644 --- a/template/en/default/admin/flag-type/edit.html.tmpl +++ b/template/en/default/admin/flag-type/edit.html.tmpl @@ -52,7 +52,7 @@ @@ -66,6 +66,7 @@ cols = 80 defaultcontent = type.description disabled = !can_fully_edit + mandatory = 1 %] @@ -129,7 +130,7 @@ don't care what order the types appear in or if you want them to appear in alphabetical order.
+ maxlength="5" [% ' disabled="disabled"' UNLESS can_fully_edit %] required> diff --git a/template/en/default/admin/groups/create.html.tmpl b/template/en/default/admin/groups/create.html.tmpl index 06396926c..8f9be1c7a 100644 --- a/template/en/default/admin/groups/create.html.tmpl +++ b/template/en/default/admin/groups/create.html.tmpl @@ -21,11 +21,11 @@
Password:
 
New password: - +
Confirm new password: - +
  diff --git a/template/en/default/admin/classifications/edit-common.html.tmpl b/template/en/default/admin/classifications/edit-common.html.tmpl index 9dd6c1676..c2bae5c42 100644 --- a/template/en/default/admin/classifications/edit-common.html.tmpl +++ b/template/en/default/admin/classifications/edit-common.html.tmpl @@ -13,7 +13,7 @@
Classification:
Description:
+ value="[% field.description FILTER html %]" required> diff --git a/template/en/default/admin/fieldvalues/create.html.tmpl b/template/en/default/admin/fieldvalues/create.html.tmpl index 4d07d5b0e..8d1dbc8b9 100644 --- a/template/en/default/admin/fieldvalues/create.html.tmpl +++ b/template/en/default/admin/fieldvalues/create.html.tmpl @@ -29,7 +29,7 @@ + maxlength="[% constants.MAX_FIELD_VALUE_SIZE FILTER none %]" required>
a short name identifying this type.
+ maxlength="50" [%- ' disabled="disabled"' UNLESS can_fully_edit %] required>
- + - + diff --git a/template/en/default/admin/groups/edit.html.tmpl b/template/en/default/admin/groups/edit.html.tmpl index c9883ce42..1cc948ea2 100644 --- a/template/en/default/admin/groups/edit.html.tmpl +++ b/template/en/default/admin/groups/edit.html.tmpl @@ -32,7 +32,7 @@ diff --git a/template/en/default/bug/field.html.tmpl b/template/en/default/bug/field.html.tmpl index b3b92e198..88200fdfa 100644 --- a/template/en/default/bug/field.html.tmpl +++ b/template/en/default/bug/field.html.tmpl @@ -42,13 +42,13 @@ value="[% value FILTER html %]" size="40" maxlength="[% constants.MAX_FREETEXT_LENGTH FILTER none %]" [% ' pattern="\d+"' IF field.type == constants.FIELD_TYPE_INTEGER %] - [% ' aria-required="true"' IF field.is_mandatory %]> + [% ' aria-required="true" required' IF field.is_mandatory %]> [% CASE [constants.FIELD_TYPE_DATETIME, constants.FIELD_TYPE_DATE] %] [% size = (field.type == constants.FIELD_TYPE_DATE) ? 10 : 20 %]
Group Name:
Description:
User Regexp: [% IF group.is_bug_group %] + value="[% group.name FILTER html %]" required> [% ELSE %] [% group.name FILTER html %] [% END %] @@ -44,7 +44,7 @@ [% IF group.is_bug_group %] + value="[% group.description FILTER html %]" required> [% ELSE %] [% group.description FILTER html %] [% END %] diff --git a/template/en/default/admin/keywords/create.html.tmpl b/template/en/default/admin/keywords/create.html.tmpl index 3c310cce0..21ecaf920 100644 --- a/template/en/default/admin/keywords/create.html.tmpl +++ b/template/en/default/admin/keywords/create.html.tmpl @@ -20,7 +20,7 @@ - + @@ -30,6 +30,7 @@ minrows = 4 cols = 64 wrap = 'virtual' + mandatory = 1 %] diff --git a/template/en/default/admin/keywords/edit.html.tmpl b/template/en/default/admin/keywords/edit.html.tmpl index 1c3d1c3c5..23158d36f 100644 --- a/template/en/default/admin/keywords/edit.html.tmpl +++ b/template/en/default/admin/keywords/edit.html.tmpl @@ -20,7 +20,7 @@ + value="[% keyword.name FILTER html %]" required> @@ -31,6 +31,7 @@ cols = 64 wrap = 'virtual' defaultcontent = keyword.description + mandatory = 1 %] diff --git a/template/en/default/admin/milestones/create.html.tmpl b/template/en/default/admin/milestones/create.html.tmpl index d15e43d55..4f1a24144 100644 --- a/template/en/default/admin/milestones/create.html.tmpl +++ b/template/en/default/admin/milestones/create.html.tmpl @@ -25,7 +25,7 @@ + autofocus required> diff --git a/template/en/default/admin/milestones/edit.html.tmpl b/template/en/default/admin/milestones/edit.html.tmpl index 86d0ebc1e..cbc7330fe 100644 --- a/template/en/default/admin/milestones/edit.html.tmpl +++ b/template/en/default/admin/milestones/edit.html.tmpl @@ -26,7 +26,7 @@ + [%- milestone.name FILTER html %]" required> diff --git a/template/en/default/admin/products/create.html.tmpl b/template/en/default/admin/products/create.html.tmpl index da63a2ff5..b34f67b62 100644 --- a/template/en/default/admin/products/create.html.tmpl +++ b/template/en/default/admin/products/create.html.tmpl @@ -37,7 +37,7 @@ diff --git a/template/en/default/admin/products/edit-common.html.tmpl b/template/en/default/admin/products/edit-common.html.tmpl index 6faa07469..baf5015ae 100644 --- a/template/en/default/admin/products/edit-common.html.tmpl +++ b/template/en/default/admin/products/edit-common.html.tmpl @@ -22,12 +22,12 @@ - diff --git a/template/en/default/admin/sudo.html.tmpl b/template/en/default/admin/sudo.html.tmpl index a5f13a015..d4faf4ea7 100644 --- a/template/en/default/admin/sudo.html.tmpl +++ b/template/en/default/admin/sudo.html.tmpl @@ -41,6 +41,7 @@ value => target_login_default accesskey => "u" size => 30 + mandatory => 1 %]

@@ -69,7 +70,7 @@ password: - +
This is done for two reasons. First of all, it is done to reduce the chances of someone doing large amounts of damage using your diff --git a/template/en/default/admin/users/userdata.html.tmpl b/template/en/default/admin/users/userdata.html.tmpl index 8cdc767e4..c08cd0018 100644 --- a/template/en/default/admin/users/userdata.html.tmpl +++ b/template/en/default/admin/users/userdata.html.tmpl @@ -23,7 +23,7 @@ [% IF editusers %] + [%- " autofocus" UNLESS editform %] required> [% IF editform %] [% IF !otheruser.in_group('bz_sudo_protect') %]
@@ -72,7 +72,7 @@ + value="" required>
Name:
Description:
Name:
Description:
Version: + value="[% version FILTER html %]" required>
Product: + value="[% product.name FILTER html %]" required>
Description:
+ value="" autocomplete="off" [% 'required' IF !editform %]> [% IF password_complexity == "mixed_letters" %] (Password must contain at least one UPPER and one lowercase letter.) [% ELSIF password_complexity == "letters_numbers" %] diff --git a/template/en/default/admin/versions/create.html.tmpl b/template/en/default/admin/versions/create.html.tmpl index 46bd38c17..648adcebd 100644 --- a/template/en/default/admin/versions/create.html.tmpl +++ b/template/en/default/admin/versions/create.html.tmpl @@ -25,7 +25,7 @@
diff --git a/template/en/default/admin/versions/edit.html.tmpl b/template/en/default/admin/versions/edit.html.tmpl index 4ea202c04..1ef0b2f66 100644 --- a/template/en/default/admin/versions/edit.html.tmpl +++ b/template/en/default/admin/versions/edit.html.tmpl @@ -26,7 +26,7 @@
+ value="[% version.name FILTER html %]" required>