From 76d1a3dce027679850d12c2857dc4263962f1f52 Mon Sep 17 00:00:00 2001
From: Frédéric Buclin
Date: Fri, 8 Jan 2016 18:31:05 +0100
Subject: Bug 1235772: Display all text/* attachments as plain text in the
"Details" page r=gerv
---
template/en/default/attachment/edit.html.tmpl | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
(limited to 'template')
diff --git a/template/en/default/attachment/edit.html.tmpl b/template/en/default/attachment/edit.html.tmpl
index d3d5dae95..31dd91c8c 100644
--- a/template/en/default/attachment/edit.html.tmpl
+++ b/template/en/default/attachment/edit.html.tmpl
@@ -190,9 +190,12 @@
[% END %]
- [% ELSIF attachment.contenttype == "text/html" %]
+ [% ELSIF attachment.contenttype.match('^text/') %]
[%# For security reasons (clickjacking, embedded scripts), we never
- # render HTML pages from here. The source code is displayed instead. %]
+ # render HTML, XML or SVG pages directly. The source code for all
+ # text/* MIME types is displayed instead. If someone tries to abuse
+ # Bugzilla by manually editing the MIME type, it will be caught
+ # by the iframe below, thanks to its 'sandbox' attribute. %]
[% INCLUDE global/textarea.html.tmpl
id = 'viewFrame'
minrows = 10
@@ -201,6 +204,8 @@
readonly = 'readonly'
%]
[% ELSE %]
+ [%# The 'sandbox' attribute causes all scripts and form submissions
+ # embedded in the attachment to be disabled, for security reasons. %]