From 2137f365677d836e3d3c55c81634d0f732fecdfe Mon Sep 17 00:00:00 2001 From: Frédéric Buclin Date: Mon, 6 Aug 2012 23:44:33 +0200 Subject: Bug 706271: CSRF vulnerability in token.cgi allows possible unauthorized password reset e-mail request r=reed a=LpSolit --- template/en/default/account/auth/login-small.html.tmpl | 7 ++++--- template/en/default/account/auth/login.html.tmpl | 1 + 2 files changed, 5 insertions(+), 3 deletions(-) (limited to 'template') diff --git a/template/en/default/account/auth/login-small.html.tmpl b/template/en/default/account/auth/login-small.html.tmpl index fbe40fb43..cb4335466 100644 --- a/template/en/default/account/auth/login-small.html.tmpl +++ b/template/en/default/account/auth/login-small.html.tmpl @@ -36,8 +36,8 @@ [% IF cgi.request_method == "GET" AND cgi.query_string %] [% connector = "&" %] [% END %] - [% script_name = login_target _ connector _ "GoAheadAndLogIn=1" %] - Log In [% Hook.process('additional_methods') %] @@ -114,7 +114,7 @@
  • | - Forgot Password
    @@ -123,6 +123,7 @@ + [x]
    • diff --git a/template/en/default/account/auth/login.html.tmpl b/template/en/default/account/auth/login.html.tmpl index 122ef6f7c..3de52b6a0 100644 --- a/template/en/default/account/auth/login.html.tmpl +++ b/template/en/default/account/auth/login.html.tmpl @@ -115,6 +115,7 @@ enter your login name below and submit a request to change your password.
    + [% END %] -- cgit v1.2.3-24-g4f1b From 36ffbcd533ca1a98224e7240a039c59786a24bbd Mon Sep 17 00:00:00 2001 From: Frédéric Buclin Date: Mon, 20 Aug 2012 11:02:24 +0200 Subject: Bug 698068: The "There is no saved search named ..." page has a "forget" link r=glob a=LpSolit --- template/en/default/global/user-error.html.tmpl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'template') diff --git a/template/en/default/global/user-error.html.tmpl b/template/en/default/global/user-error.html.tmpl index 3d1ac5c53..5536d9fd2 100644 --- a/template/en/default/global/user-error.html.tmpl +++ b/template/en/default/global/user-error.html.tmpl @@ -1177,7 +1177,7 @@ [% title = "Missing Search" %] [% docslinks = {'query.html' => "Searching for $terms.bugs", 'query.html#list' => "$terms.Bug lists"} %] - The search named [% queryname FILTER html %] + The search named [% name FILTER html %] [% IF sharer_id && sharer_id != user.id %] has not been made visible to you. [% ELSE %] -- cgit v1.2.3-24-g4f1b From b412d2636fd4997389a5ecad459c2e31adf670fc Mon Sep 17 00:00:00 2001 From: Frédéric Buclin Date: Mon, 27 Aug 2012 20:14:49 +0200 Subject: Bug 785917: Custom field descriptions are not properly escaped when displayed as bug list column headers r=glob a=LpSolit --- template/en/default/filterexceptions.pl | 1 - template/en/default/list/table.html.tmpl | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) (limited to 'template') diff --git a/template/en/default/filterexceptions.pl b/template/en/default/filterexceptions.pl index 8680573fb..496c60bb6 100644 --- a/template/en/default/filterexceptions.pl +++ b/template/en/default/filterexceptions.pl @@ -154,7 +154,6 @@ 'list/table.html.tmpl' => [ 'tableheader', 'bug.bug_id', - 'abbrev.$id.title || field_descs.$id || column.title', ], 'list/list.csv.tmpl' => [ diff --git a/template/en/default/list/table.html.tmpl b/template/en/default/list/table.html.tmpl index 2b266d4ce..a074fcbd0 100644 --- a/template/en/default/list/table.html.tmpl +++ b/template/en/default/list/table.html.tmpl @@ -133,7 +133,7 @@ [% PROCESS new_order %] [%-#%]&query_based_on= [% defaultsavename OR searchname FILTER uri %]"> - [%- abbrev.$id.title || field_descs.$id || column.title -%] + [%- abbrev.$id.title || field_descs.$id || column.title FILTER html -%] [% PROCESS order_arrow ~%] -- cgit v1.2.3-24-g4f1b From beae46063bcb62deddd6e72c2e34388b3c265da0 Mon Sep 17 00:00:00 2001 From: Byron Jones Date: Wed, 29 Aug 2012 00:35:50 +0800 Subject: Bug 772953: Remove the token from buglist urls r=dkl, a=LpSolit --- template/en/default/search/search-advanced.html.tmpl | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) (limited to 'template') diff --git a/template/en/default/search/search-advanced.html.tmpl b/template/en/default/search/search-advanced.html.tmpl index ef7fa769a..780d54edd 100644 --- a/template/en/default/search/search-advanced.html.tmpl +++ b/template/en/default/search/search-advanced.html.tmpl @@ -31,7 +31,13 @@ [% js_data = BLOCK %] -var queryform = "queryform" +var queryform = "queryform"; +function remove_token() { + if (queryform.token) { + var asDefault = document.getElementById('remasdefault'); + queryform.token.disabled = !asDefault.checked; + } +} [% END %] [% PROCESS global/header.html.tmpl @@ -53,7 +59,8 @@ var queryform = "queryform"

    Hover your mouse over each field label to get help for that field.

    -
    + [% PROCESS search/form.html.tmpl %] -- cgit v1.2.3-24-g4f1b From f018846b89955e844b2896ea3d5e2b3e4962cd42 Mon Sep 17 00:00:00 2001 From: Frédéric Buclin Date: Thu, 30 Aug 2012 00:14:29 +0200 Subject: Bug 786351: Release notes for Bugzilla 4.2.3 r=dkl a=LpSolit --- template/en/default/pages/release-notes.html.tmpl | 41 +++++++++++++++++++++++ 1 file changed, 41 insertions(+) (limited to 'template') diff --git a/template/en/default/pages/release-notes.html.tmpl b/template/en/default/pages/release-notes.html.tmpl index 11c5d5460..35963148a 100644 --- a/template/en/default/pages/release-notes.html.tmpl +++ b/template/en/default/pages/release-notes.html.tmpl @@ -53,6 +53,44 @@

    Updates in this 4.2.x Release

    +

    4.2.3

    + +

    This release fixes two security issues. See the + Security Advisory + for details.

    + +

    In addition, the following important fixes/changes have been made in this + release:

    + +
      +
    • Attaching a file to [% terms.abug %] was broken due to a change in + Perl 5.16. + ([% terms.Bug %] 771100)
      • +
    • A regression in [% terms.Bugzilla %] 4.2.2 made Oracle crash when + displaying a buglist. + ([% terms.Bug %] 780028)
      • +
    • It was possible to search on history for comments and attachments you + cannot see (though these private comments and attachments are never disclosed). + ([% terms.Bug %] 779709)
      • +
    • PostgreSQL databases could be created with the wrong encoding despite + the utf8 parameter being enabled. + ([% terms.Bug %] 783786)
      • +
    • Scheduled whines could be sent at the wrong time on Oracle. + ([% terms.Bug %] 559539)
      • +
    • Tokens are no longer included in saved queries. + ([% terms.Bug %] 772953)
      • +
    • An admin could unintentionally break the display of buglists if a custom + field description contains a < or > character, because these characters + were not filtered. + ([% terms.Bug %] 785917)
      • +
    • Adding or removing a DB column in Oracle didn't handle SERIAL columns + correctly. + ([% terms.Bug %] 731156)
      • +
    • A minor CSRF vulnerability in token.cgi allowed possible unauthorized + password reset e-mail requests. + ([% terms.Bug %] 706271)
      • +
    +

    4.2.2

    This release fixes two security issues. See the @@ -432,6 +470,9 @@ [%- terms.Bug %] 584742: When viewing [% terms.abug %], WebKit-based browsers can automatically reset a field's selected value when the field has disabled values. +

  • + [%- terms.Bug %] 780053: Oracle crashes when listing keywords, tags + or flags in buglists.
    • -- cgit v1.2.3-24-g4f1b