From b3a503abcdb34861e51841a4bf87af044a13acd4 Mon Sep 17 00:00:00 2001 From: Sunil Joshi Date: Fri, 16 Nov 2012 16:14:20 +0100 Subject: Bug 578762: When moving a bug into another product, the "Verify Bug Group" section should not appear if no groups are applicable r/a=LpSolit --- .../bug/process/verify-new-product.html.tmpl | 35 ++++++++++++---------- 1 file changed, 19 insertions(+), 16 deletions(-) (limited to 'template') diff --git a/template/en/default/bug/process/verify-new-product.html.tmpl b/template/en/default/bug/process/verify-new-product.html.tmpl index 45727901c..77471cbcd 100644 --- a/template/en/default/bug/process/verify-new-product.html.tmpl +++ b/template/en/default/bug/process/verify-new-product.html.tmpl @@ -100,7 +100,25 @@ [% IF verify_bug_groups %] -

Verify [% terms.Bug %] Group

+ [% mandatory_groups = [] %] + [% optional_groups = [] %] + + [% FOREACH gid = product.group_controls.keys %] + [% group = product.group_controls.$gid %] + [% NEXT UNLESS group.group.is_active %] + + [% IF group.membercontrol == constants.CONTROLMAPMANDATORY + || (group.othercontrol == constants.CONTROLMAPMANDATORY && !user.in_group(group.group.name)) %] + [% mandatory_groups.push(group) %] + [% ELSIF (group.membercontrol != constants.CONTROLMAPNA && user.in_group(group.group.name)) + || group.othercontrol != constants.CONTROLMAPNA %] + [% optional_groups.push(group) %] + [% END %] + [% END %] + + [% IF old_groups.size || optional_groups.size || mandatory_groups.size %] +

Verify [% terms.Bug %] Group

+ [% END %] [% IF old_groups.size %]

These groups are not legal for the '[% product.name FILTER html %]' @@ -118,21 +136,6 @@

[% END %] - [% mandatory_groups = [] %] - [% optional_groups = [] %] - - [% FOREACH gid = product.group_controls.keys %] - [% group = product.group_controls.$gid %] - [% NEXT UNLESS group.group.is_active %] - - [% IF group.membercontrol == constants.CONTROLMAPMANDATORY - || (group.othercontrol == constants.CONTROLMAPMANDATORY && !user.in_group(group.group.name)) %] - [% mandatory_groups.push(group) %] - [% ELSIF (group.membercontrol != constants.CONTROLMAPNA && user.in_group(group.group.name)) - || group.othercontrol != constants.CONTROLMAPNA %] - [% optional_groups.push(group) %] - [% END %] - [% END %] [% IF optional_groups.size %]

These groups are optional. You can decide to restrict [% terms.bugs %] to -- cgit v1.2.3-24-g4f1b