From b7656f0a5deec13cd706c5fa364ec52e21b749b1 Mon Sep 17 00:00:00 2001 From: Simon Green Date: Thu, 11 Oct 2012 14:31:06 +0800 Subject: Bug 798994: Fix incorrect double escaping when displaying saved queries URLs r=glob, a=LpSolit --- template/en/default/global/user-error.html.tmpl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'template') diff --git a/template/en/default/global/user-error.html.tmpl b/template/en/default/global/user-error.html.tmpl index 5536d9fd2..4269d693d 100644 --- a/template/en/default/global/user-error.html.tmpl +++ b/template/en/default/global/user-error.html.tmpl @@ -1809,7 +1809,7 @@ [% FOREACH q = Bugzilla.user.queries %] [% IF q.name == namedcmd %] - or edit + or edit [% END %] [% END %] -- cgit v1.2.3-24-g4f1b From be7354cbea019cd0220e16119f70e0885d0326fe Mon Sep 17 00:00:00 2001 From: Frédéric Buclin Date: Fri, 26 Oct 2012 17:13:05 +0200 Subject: Bug 805647: Release notes for Bugzilla 4.2.4 r=dkl --- template/en/default/pages/release-notes.html.tmpl | 53 +++++++++++++++++++++-- 1 file changed, 50 insertions(+), 3 deletions(-) (limited to 'template') diff --git a/template/en/default/pages/release-notes.html.tmpl b/template/en/default/pages/release-notes.html.tmpl index 35963148a..86a12af8d 100644 --- a/template/en/default/pages/release-notes.html.tmpl +++ b/template/en/default/pages/release-notes.html.tmpl @@ -53,6 +53,53 @@

Updates in this 4.2.x Release

+

4.2.4

+ +

This release fixes several security issues. See the + Security Advisory + for details.

+ +

In addition, the following important fixes/changes have been made in this + release:

+ + +

4.2.3

This release fixes two security issues. See the @@ -129,7 +176,7 @@ ([% terms.Bug %] 768870)

  • Two minor CSRF vulnerabilities have been fixed which could let an attacker alter your default search criteria in the Advanced Search page. - ([% terms.Bugs %] 754672 + ([% terms.Bugs %] 754672 and 754673)
    • @@ -613,8 +660,8 @@ ([% terms.Bug %] 640719)
  • Email notifications about dependencies and flags had the wrong timestamp. - ([% terms.Bug %] 643910 - and ([% terms.Bug %] 652165)
    • + ([% terms.Bugs %] 643910 + and 652165)
  • You can now select "UTC" as a valid timezone in General Preferences. ([% terms.Bug %] 646209)
  • Automatic duplicate detection now works on PostgreSQL (although -- cgit v1.2.3-24-g4f1b From 3005f1cc32b216a5298bc32e3668bb4a0c577baa Mon Sep 17 00:00:00 2001 From: Frédéric Buclin Date: Sat, 3 Nov 2012 18:53:41 +0100 Subject: Bug 805647: One more item for the 4.2.4 release notes --- template/en/default/pages/release-notes.html.tmpl | 3 +++ 1 file changed, 3 insertions(+) (limited to 'template') diff --git a/template/en/default/pages/release-notes.html.tmpl b/template/en/default/pages/release-notes.html.tmpl index 86a12af8d..277c61ff0 100644 --- a/template/en/default/pages/release-notes.html.tmpl +++ b/template/en/default/pages/release-notes.html.tmpl @@ -77,6 +77,9 @@ ([% terms.Bug %] 793826)
  • PostgreSQL 9.2 requires DBD::Pg 2.19.3. ([% terms.Bug %] 799721)
    • +
  • New databases created with PostgreSQL were sometimes not correctly encoded + as UTF8. + ([% terms.Bug %] 783786)
  • Oracle was crashing when listing keywords or flags in buglists. ([% terms.Bug %] 780053)
  • Oracle was crashing when typing several bare words in the QuickSearch field. -- cgit v1.2.3-24-g4f1b From 798135a6e855d992b734d002805ac4dd909be2cc Mon Sep 17 00:00:00 2001 From: Frédéric Buclin Date: Sat, 3 Nov 2012 19:58:26 +0100 Subject: Back out the last checkin, it was already there --- template/en/default/pages/release-notes.html.tmpl | 3 --- 1 file changed, 3 deletions(-) (limited to 'template') diff --git a/template/en/default/pages/release-notes.html.tmpl b/template/en/default/pages/release-notes.html.tmpl index 277c61ff0..86a12af8d 100644 --- a/template/en/default/pages/release-notes.html.tmpl +++ b/template/en/default/pages/release-notes.html.tmpl @@ -77,9 +77,6 @@ ([% terms.Bug %] 793826)
  • PostgreSQL 9.2 requires DBD::Pg 2.19.3. ([% terms.Bug %] 799721)
    • -
  • New databases created with PostgreSQL were sometimes not correctly encoded - as UTF8. - ([% terms.Bug %] 783786)
  • Oracle was crashing when listing keywords or flags in buglists. ([% terms.Bug %] 780053)
  • Oracle was crashing when typing several bare words in the QuickSearch field. -- cgit v1.2.3-24-g4f1b From fbb0dd18cbf1ddf2e63c2db7c0bce98001a704ea Mon Sep 17 00:00:00 2001 From: Frédéric Buclin Date: Tue, 13 Nov 2012 18:09:30 +0100 Subject: Bug 731178 (CVE-2012-4199): [SECURITY] field-events.js.tmpl discloses product and component names that the user is not allowed to see r=dkl a=LpSolit --- template/en/default/bug/edit.html.tmpl | 12 ++++++------ template/en/default/bug/field-events.js.tmpl | 18 +++++++++++++++--- 2 files changed, 21 insertions(+), 9 deletions(-) (limited to 'template') diff --git a/template/en/default/bug/edit.html.tmpl b/template/en/default/bug/edit.html.tmpl index bdee83806..fbc6e4a96 100644 --- a/template/en/default/bug/edit.html.tmpl +++ b/template/en/default/bug/edit.html.tmpl @@ -30,9 +30,8 @@ [% PROCESS bug/time.html.tmpl %] - +[% END %] +//--> +
    diff --git a/template/en/default/bug/field-events.js.tmpl b/template/en/default/bug/field-events.js.tmpl index 13ec18d38..f1d5afd32 100644 --- a/template/en/default/bug/field-events.js.tmpl +++ b/template/en/default/bug/field-events.js.tmpl @@ -24,11 +24,23 @@ #%] [% FOREACH controlled_field = field.controls_visibility_of %] + [% vis_names = [] %] + [% FOREACH visibility_value = controlled_field.visibility_values %] + [%# Exclude non-enterable products and components outside the current product. %] + [% NEXT IF field.name == "product" + && visibility_value.id != product.id + && !user.can_enter_product(visibility_value) %] + [% NEXT IF field.name == "component" && visibility_value.product_id != product.id %] + [% vis_names.push(visibility_value.name) %] + [% END %] + + [% NEXT UNLESS vis_names.size %] + showFieldWhen('[% controlled_field.name FILTER js %]', '[% field.name FILTER js %]', [ - [%- FOREACH visibility_value = controlled_field.visibility_values -%] - '[%- visibility_value.name FILTER js -%]'[% "," UNLESS loop.last %] - [%- END %] + [%~ FOREACH vis_name = vis_names ~%] + '[% vis_name FILTER js %]'[% "," UNLESS loop.last %] + [%~ END ~%] ]); [% END %] -- cgit v1.2.3-24-g4f1b From be126b5b3ce49ae4d3c1591cccca40cb369c4dd3 Mon Sep 17 00:00:00 2001 From: Frédéric Buclin Date: Tue, 13 Nov 2012 18:23:13 +0100 Subject: Bug 802204 (CVE-2012-4197): [SECURITY] Marking an attachment you cannot see as obsolete can disclose its description r=gerv a=LpSolit --- template/en/default/global/code-error.html.tmpl | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'template') diff --git a/template/en/default/global/code-error.html.tmpl b/template/en/default/global/code-error.html.tmpl index 73a602b87..24e46fb14 100644 --- a/template/en/default/global/code-error.html.tmpl +++ b/template/en/default/global/code-error.html.tmpl @@ -244,8 +244,7 @@ setting in [% constants.bz_locations.localconfig FILTER html %]. [% ELSIF error == "mismatched_bug_ids_on_obsolete" %] - Attachment [% attach_id FILTER html %] ([% description FILTER html %]) - is attached to [% terms.bug %] [%+ attach_bug_id FILTER html %], + Attachment [% attach_id FILTER html %] is attached to another [% terms.bug %], but you tried to flag it as obsolete while creating a new attachment to [%+ terms.bug %] [%+ my_bug_id FILTER html %]. -- cgit v1.2.3-24-g4f1b From 3a3636a8e51513cda6979bf13c02f573d1e9737f Mon Sep 17 00:00:00 2001 From: Frédéric Buclin Date: Tue, 13 Nov 2012 18:56:26 +0100 Subject: Bug 790296 (CVE-2012-4189): [SECURITY] Field values are not escaped correctly in tabular reports r=dkl a=LpSolit --- template/en/default/reports/report-table.html.tmpl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'template') diff --git a/template/en/default/reports/report-table.html.tmpl b/template/en/default/reports/report-table.html.tmpl index 8a3ab9524..b41753550 100644 --- a/template/en/default/reports/report-table.html.tmpl +++ b/template/en/default/reports/report-table.html.tmpl @@ -102,7 +102,7 @@ YAHOO.util.Event.addListener(window, "load", function() { var myColumnDefs = [ {key:"row_title", label:"", sortable:true, sortOptions: { sortFunction:totalNumberSorter }}, [% FOREACH col = col_names %] - {key:"[% col FILTER js %]", label:"[% display_value(col_field, col) FILTER js %]", sortable:true, + {key:"[% col FILTER js %]", label:"[% display_value(col_field, col) FILTER html FILTER js %]", sortable:true, formatter:this.Linkify, sortOptions: { defaultDir: YAHOO.widget.DataTable.CLASS_DESC, sortFunction:totalNumberSorter }}, [% END %] {key:"total", label:"Total", sortable:true, formatter:this.LinkifyTotal, -- cgit v1.2.3-24-g4f1b