From 7fda8c351dd6c9621d85c9b29c5c6baa2f1eaba3 Mon Sep 17 00:00:00 2001
From: "mkanat%bugzilla.org" <>
Date: Fri, 11 Sep 2009 16:05:48 +0000
Subject: Bug 508189: (CVE-2009-3166) [SECURITY] Logging in after changing your
 password would expose your new password in the URL Patch by Max
 Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=mkanat

---
 token.cgi | 4 ++++
 1 file changed, 4 insertions(+)

(limited to 'token.cgi')

diff --git a/token.cgi b/token.cgi
index 1e62bb8a0..614feefa9 100755
--- a/token.cgi
+++ b/token.cgi
@@ -130,6 +130,8 @@ if ( $action eq 'chgpw' ) {
       || ThrowUserError("require_new_password");
 
     validate_password($password, $cgi->param('matchpassword'));
+    # Make sure that these never show up in the UI under any circumstances.
+    $cgi->delete('password', 'matchpassword');
 }
 
 ################################################################################
@@ -378,6 +380,8 @@ sub confirm_create_account {
 
     my $password = $cgi->param('passwd1') || '';
     validate_password($password, $cgi->param('passwd2') || '');
+    # Make sure that these never show up anywhere in the UI.
+    $cgi->delete('passwd1', 'passwd2');
 
     my $otheruser = Bugzilla::User->create({
         login_name => $login_name, 
-- 
cgit v1.2.3-24-g4f1b