From 11fa9ce3596363a4d4badd7960ae73e8dc535050 Mon Sep 17 00:00:00 2001 From: "lpsolit%gmail.com" <> Date: Thu, 8 Jan 2009 00:06:49 +0000 Subject: Bug 472549: Ignore undefined values when committing user pref changes - Patch by Frédéric Buclin r/a=mkanat MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- userprefs.cgi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'userprefs.cgi') diff --git a/userprefs.cgi b/userprefs.cgi index 1bf2d7f5f..085372bac 100755 --- a/userprefs.cgi +++ b/userprefs.cgi @@ -127,7 +127,6 @@ sub SaveAccount { $cgi->param('Bugzilla_password') || ThrowUserError("old_password_required"); - use Bugzilla::Token; # Block multiple email changes for the same user. if (Bugzilla::Token::HasEmailChangeToken($user->id)) { ThrowUserError("email_change_in_progress"); @@ -183,6 +182,7 @@ sub SaveSettings { foreach my $name (@setting_list) { next if ! ($settings->{$name}->{'is_enabled'}); my $value = $cgi->param($name); + next unless defined $value; my $setting = new Bugzilla::User::Setting($name); if ($value eq "${name}-isdefault" ) { -- cgit v1.2.3-24-g4f1b