From 5f9f484fadbdc28be6b0c6b9ab0b67b6fd4d0e9c Mon Sep 17 00:00:00 2001
From: "lpsolit%gmail.com" <>
Date: Wed, 20 Jul 2005 09:14:24 +0000
Subject: Bug 257767: Option to have fields in CSV files separated by
 semicolons instead of commas - Patch by Marc Schumann <wurblzap@gmail.com>
 r=LpSolit a=myk

---
 userprefs.cgi | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

(limited to 'userprefs.cgi')

diff --git a/userprefs.cgi b/userprefs.cgi
index 07042beac..5f52a3ca7 100755
--- a/userprefs.cgi
+++ b/userprefs.cgi
@@ -152,18 +152,16 @@ sub SaveSettings {
     foreach my $name (@setting_list) {
         next if ! ($settings->{$name}->{'is_enabled'});
         my $value = $cgi->param($name);
+        my $setting = new Bugzilla::User::Setting($name);
 
-        # de-taint the value.
-        if ($value =~ /^([-\w]+)$/ ) {
-            $value = $1;
-        }
         if ($value eq "${name}-isdefault" ) {
             if (! $settings->{$name}->{'is_default'}) {
-                 $settings->{$name}->reset_to_default;
+                $settings->{$name}->reset_to_default;
             }
         }
         else {
-           $settings->{$name}->set($value);
+            $setting->validate_value($value);
+            $settings->{$name}->set($value);
         }
     }
     $vars->{'settings'} = Bugzilla->user->settings(1);
-- 
cgit v1.2.3-24-g4f1b