From 5ccff95a61b0c0816fa42da061c298f794daf33d Mon Sep 17 00:00:00 2001 From: Dave Lawrence Date: Tue, 26 Feb 2013 15:57:37 -0500 Subject: Bug 836067 - backport bug 819432 to BMO 4.2 to improve search performance --- whine.pl | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) (limited to 'whine.pl') diff --git a/whine.pl b/whine.pl index ad6067228..e6161cfeb 100755 --- a/whine.pl +++ b/whine.pl @@ -453,7 +453,7 @@ sub run_queries { 'user' => $args->{'recipient'}, # the search runs as the recipient ); # If a query fails for whatever reason, it shouldn't kill the script. - my $sqlquery = eval { $search->sql }; + my $data = eval { $search->data }; if ($@) { print STDERR get_text('whine_query_failed', { query_name => $thisquery->{'name'}, author => $args->{'author'}, @@ -461,15 +461,12 @@ sub run_queries { next; } - $sth = $dbh->prepare($sqlquery); - $sth->execute; - - while (my @row = $sth->fetchrow_array) { + foreach my $row (@$data) { my $bug = {}; for my $field (@searchfields) { my $fieldname = $field; $fieldname =~ s/^bugs\.//; # No need for bugs.whatever - $bug->{$fieldname} = shift @row; + $bug->{$fieldname} = shift @$row; } if ($thisquery->{'onemailperbug'}) { -- cgit v1.2.3-24-g4f1b