From f0b6242097e487198de559d39d4169a2a0a4d8e7 Mon Sep 17 00:00:00 2001 From: Tiago Mello Date: Thu, 10 Feb 2011 23:31:28 -0200 Subject: Bug 620827: Refactor remove see also to use remove_from_db instead. r/a=mkanat --- xt/lib/Bugzilla/Test/Search.pm | 4 ++-- xt/lib/Bugzilla/Test/Search/FieldTest.pm | 7 +++++-- 2 files changed, 7 insertions(+), 4 deletions(-) (limited to 'xt/lib') diff --git a/xt/lib/Bugzilla/Test/Search.pm b/xt/lib/Bugzilla/Test/Search.pm index 857af6cb3..3465991f1 100644 --- a/xt/lib/Bugzilla/Test/Search.pm +++ b/xt/lib/Bugzilla/Test/Search.pm @@ -655,8 +655,8 @@ sub _create_one_bug { $dbh->do('UPDATE bugs SET creation_ts = ?, bug_status = ?, resolution = ? WHERE bug_id = ?', undef, $creation_ts, $status, $resolution, $bug->id); - $dbh->do('INSERT INTO bug_see_also (bug_id, value) VALUES (?,?)', - undef, $bug->id, $see_also); + $dbh->do('INSERT INTO bug_see_also (bug_id, value, class) VALUES (?,?,?)', + undef, $bug->id, $see_also, 'Bugzilla::BugUrl::Bugzilla'); if ($number == 1) { # Bug 1 needs to start off with reporter_accessible and diff --git a/xt/lib/Bugzilla/Test/Search/FieldTest.pm b/xt/lib/Bugzilla/Test/Search/FieldTest.pm index 56c0a57d6..e57fd2a59 100644 --- a/xt/lib/Bugzilla/Test/Search/FieldTest.pm +++ b/xt/lib/Bugzilla/Test/Search/FieldTest.pm @@ -347,6 +347,9 @@ sub _field_values_for_bug { elsif ($field eq 'content') { @values = $self->_values_for($number, 'short_desc'); } + elsif ($field eq 'see_also') { + @values = $self->_values_for($number, 'see_also', 'name'); + } # Bugzilla::Bug truncates creation_ts, but we need the full value # from the database. This has no special value for changedfrom, # because it never changes. @@ -385,7 +388,7 @@ sub _values_for { my $bug = $self->bug($number); $item = $bug->$bug_field; } - + if ($item_field) { if ($bug_field eq 'flags' and $item_field eq 'name') { return (map { $_->name . $_->status } @$item); @@ -592,4 +595,4 @@ sub _test_content_for_bug { } } -1; \ No newline at end of file +1; -- cgit v1.2.3-24-g4f1b