# This Source Code Form is subject to the terms of the Mozilla Public # License, v. 2.0. If a copy of the MPL was not distributed with this # file, You can obtain one at http://mozilla.org/MPL/2.0/. # # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. package Bugzilla::Memcached; use 5.10.1; use strict; use warnings; use Bugzilla::Error; use Bugzilla::Util qw(trick_taint); use Scalar::Util qw(blessed); use URI::Escape; # memcached keys have a maximum length of 250 bytes use constant MAX_KEY_LENGTH => 250; sub _new { my $invocant = shift; my $class = ref($invocant) || $invocant; my $self = {}; # always return an object to simplify calling code when memcached is # disabled. if (Bugzilla->feature('memcached') && Bugzilla->params->{memcached_servers}) { require Cache::Memcached; $self->{namespace} = Bugzilla->params->{memcached_namespace} || ''; $self->{memcached} = Cache::Memcached->new({ servers => [ split(/[, ]+/, Bugzilla->params->{memcached_servers}) ], namespace => $self->{namespace}, }); } return bless($self, $class); } sub enabled { return $_[0]->{memcached} ? 1 : 0; } sub set { my ($self, $args) = @_; return unless $self->{memcached}; # { key => $key, value => $value } if (exists $args->{key}) { $self->_set($args->{key}, $args->{value}); } # { table => $table, id => $id, name => $name, data => $data } elsif (exists $args->{table} && exists $args->{id} && exists $args->{name}) { # For caching of Bugzilla::Object, we have to be able to clear the # cached values when given either the object's id or name. my ($table, $id, $name, $data) = @$args{qw(table id name data)}; $self->_set("$table.id.$id", $data); if (defined $name) { $self->_set("$table.name_id.$name", $id); $self->_set("$table.id_name.$id", $name); } } else { ThrowCodeError('params_required', { function => "Bugzilla::Memcached::set", params => [ 'key', 'table' ] }); } } sub get { my ($self, $args) = @_; return unless $self->{memcached}; # { key => $key } if (exists $args->{key}) { return $self->_get($args->{key}); } # { table => $table, id => $id } elsif (exists $args->{table} && exists $args->{id}) { my ($table, $id) = @$args{qw(table id)}; return $self->_get("$table.id.$id"); } # { table => $table, name => $name } elsif (exists $args->{table} && exists $args->{name}) { my ($table, $name) = @$args{qw(table name)}; return unless my $id = $self->_get("$table.name_id.$name"); return $self->_get("$table.id.$id"); } else { ThrowCodeError('params_required', { function => "Bugzilla::Memcached::get", params => [ 'key', 'table' ] }); } } sub set_config { my ($self, $args) = @_; return unless $self->{memcached}; if (exists $args->{key}) { return $self->_set($self->_config_prefix . '.' . $args->{key}, $args->{data}); } else { ThrowCodeError('params_required', { function => "Bugzilla::Memcached::set_config", params => [ 'key' ] }); } } sub get_config { my ($self, $args) = @_; return unless $self->{memcached}; if (exists $args->{key}) { return $self->_get($self->_config_prefix . '.' . $args->{key}); } else { ThrowCodeError('params_required', { function => "Bugzilla::Memcached::get_config", params => [ 'key' ] }); } } sub clear { my ($self, $args) = @_; return unless $self->{memcached}; # { key => $key } if (exists $args->{key}) { $self->_delete($args->{key}); } # { table => $table, id => $id } elsif (exists $args->{table} && exists $args->{id}) { my ($table, $id) = @$args{qw(table id)}; my $name = $self->_get("$table.id_name.$id"); $self->_delete("$table.id.$id"); $self->_delete("$table.name_id.$name") if defined $name; $self->_delete("$table.id_name.$id"); } # { table => $table, name => $name } elsif (exists $args->{table} && exists $args->{name}) { my ($table, $name) = @$args{qw(table name)}; return unless my $id = $self->_get("$table.name_id.$name"); $self->_delete("$table.id.$id"); $self->_delete("$table.name_id.$name"); $self->_delete("$table.id_name.$id"); } else { ThrowCodeError('params_required', { function => "Bugzilla::Memcached::clear", params => [ 'key', 'table' ] }); } } sub clear_all { my ($self) = @_; return unless $self->{memcached}; $self->_inc_prefix("global"); } sub clear_config { my ($self, $args) = @_; return unless $self->{memcached}; if ($args && exists $args->{key}) { $self->_delete($self->_config_prefix . '.' . $args->{key}); } else { $self->_inc_prefix("config"); } } # in order to clear all our keys, we add a prefix to all our keys. when we # need to "clear" all current keys, we increment the prefix. sub _prefix { my ($self, $name) = @_; # we don't want to change prefixes in the middle of a request my $request_cache = Bugzilla->request_cache; my $request_cache_key = "memcached_prefix_$name"; if (!$request_cache->{$request_cache_key}) { my $memcached = $self->{memcached}; my $prefix = $memcached->get($name); if (!$prefix) { $prefix = time(); if (!$memcached->add($name, $prefix)) { # if this failed, either another process set the prefix, or # memcached is down. assume we lost the race, and get the new # value. if that fails, memcached is down so use a dummy # prefix for this request. $prefix = $memcached->get($name) || 0; } } $request_cache->{$request_cache_key} = $prefix; } return $request_cache->{$request_cache_key}; } sub _inc_prefix { my ($self, $name) = @_; my $memcached = $self->{memcached}; if (!$memcached->incr($name, 1)) { $memcached->add($name, time()); } delete Bugzilla->request_cache->{"memcached_prefix_$name"}; } sub _global_prefix { return $_[0]->_prefix("global"); } sub _config_prefix { return $_[0]->_prefix("config"); } sub _encode_key { my ($self, $key) = @_; $key = $self->_global_prefix . '.' . uri_escape_utf8($key); return length($self->{namespace} . $key) > MAX_KEY_LENGTH ? undef : $key; } sub _set { my ($self, $key, $value) = @_; if (blessed($value)) { # we don't support blessed objects ThrowCodeError('param_invalid', { function => "Bugzilla::Memcached::set", param => "value" }); } $key = $self->_encode_key($key) or return; return $self->{memcached}->set($key, $value); } sub _get { my ($self, $key) = @_; $key = $self->_encode_key($key) or return; my $value = $self->{memcached}->get($key); return unless defined $value; # detaint returned values # hashes and arrays are detainted just one level deep if (ref($value) eq 'HASH') { _detaint_hashref($value); } elsif (ref($value) eq 'ARRAY') { foreach my $value (@$value) { next unless defined $value; # arrays of hashes and arrays are common if (ref($value) eq 'HASH') { _detaint_hashref($value); } elsif (ref($value) eq 'ARRAY') { _detaint_arrayref($value); } elsif (!ref($value)) { trick_taint($value); } } } elsif (!ref($value)) { trick_taint($value); } return $value; } sub _detaint_hashref { my ($hashref) = @_; foreach my $value (values %$hashref) { if (defined($value) && !ref($value)) { trick_taint($value); } } } sub _detaint_arrayref { my ($arrayref) = @_; foreach my $value (@$arrayref) { if (defined($value) && !ref($value)) { trick_taint($value); } } } sub _delete { my ($self, $key) = @_; $key = $self->_encode_key($key) or return; return $self->{memcached}->delete($key); } 1; __END__ =head1 NAME Bugzilla::Memcached - Interface between Bugzilla and Memcached. =head1 SYNOPSIS use Bugzilla; my $memcached = Bugzilla->memcached; # grab data from the cache. there is no need to check if memcached is # available or enabled. my $data = $memcached->get({ key => 'data_key' }); if (!defined $data) { # not in cache, generate the data and populate the cache for next time $data = some_long_process(); $memcached->set({ key => 'data_key', value => $data }); } # do something with $data # updating the profiles table directly shouldn't be attempted unless you know # what you're doing. if you do update a table directly, you need to clear that # object from memcached. $dbh->do("UPDATE profiles SET request_count=10 WHERE login_name=?", undef, $login); $memcached->clear({ table => 'profiles', name => $login }); =head1 DESCRIPTION If Memcached is installed and configured, Bugzilla can use it to cache data across requests and between webheads. Unlike the request and process caches, only scalars, hashrefs, and arrayrefs can be stored in Memcached. Memcached integration is only required for large installations of Bugzilla -- if you have multiple webheads then configuring Memcache is recommended. L provides an interface to a Memcached server/servers, with the ability to get, set, or clear entries from the cache. The stored value must be an unblessed hashref, unblessed array ref, or a scalar. Currently nested data structures are supported but require manual de-tainting after reading from Memcached (flat data structures are automatically de-tainted). All values are stored in the Memcached systems using the prefix configured with the C parameter, as well as an additional prefix managed by this class to allow all values to be cleared when C is executed. Do not create an instance of this object directly, instead use Lmemcached()|Bugzilla/memcached>. =head1 METHODS =over =item C Returns true if Memcached support is available and enabled. =back =head2 Setting Adds a value to Memcached. =over =item C $key, value =E $value })> Adds the C using the specific C. =item C $table, id =E $id, name =E $name, data =E $data })> Adds the C using a keys generated from the C, C, and C. All three parameters must be provided, however C can be provided but set to C. This is a convenience method which allows cached data to be later retrieved by specifying the C
and either the C or C. =item C $key, data =E $data })> Adds the C using the C while identifying the data as part of Bugzilla's configuration (such as fields, products, components, groups, etc). Values set with C are automatically cleared when changes are made to Bugzilla's configuration. =back =head2 Getting Retrieves a value from Memcached. Returns C if no matching values were found in the cache. =over =item C $key })> Return C with the specified C. =item C $table, id =E $id })> Return C with the specified C
and C. =item C $table, name =E $name })> Return C with the specified C
and C. =item C $key })> Return C with the specified C from the configuration cache. See C for more information. =back =head2 Clearing Removes the matching value from Memcached. =over =item C $key })> Removes C with the specified C. =item C $table, id =E $id })> Removes C with the specified C
and C, as well as the corresponding C
and C entry. =item C $table, name =E $name })> Removes C with the specified C
and C, as well as the corresponding C
and C entry. =item C $key })> Remove C with the specified C from the configuration cache. See C for more information. =item C Removes all configuration related values from the cache. See C for more information. =item C Removes all values from the cache. =back =head1 Bugzilla::Object CACHE The main driver for Memcached integration is to allow L based objects to be automatically cached in Memcache. This is enabled on a per-package basis by setting the C constant to any true value. The current implementation is an opt-in (USE_MEMCACHED is false by default), however this will change to opt-out once further testing has been completed (USE_MEMCACHED will be true by default). =head1 DIRECT DATABASE UPDATES If an object is cached and the database is updated directly (instead of via C<$object-Eupdate()>), then it's possible for the data in the cache to be out of sync with the database. As an example let's consider an extension which adds a timestamp field C to the profiles table and user object which contains the user's last activity. If the extension were to call C<$user-Eupdate()>, then an audit entry would be created for each change to the C field, which is undesirable. To remedy this, the extension updates the table directly. It's critical with Memcached that it then clears the cache: $dbh->do("UPDATE profiles SET last_activity_ts=? WHERE userid=?", undef, $timestamp, $user_id); Bugzilla->memcached->clear({ table => 'profiles', id => $user_id });